From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MjKdS-0008KI-Hh for qemu-devel@nongnu.org; Thu, 03 Sep 2009 18:18:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MjKdO-0008HG-3y for qemu-devel@nongnu.org; Thu, 03 Sep 2009 18:18:30 -0400 Received: from [199.232.76.173] (port=39505 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MjKdN-0008HC-Rx for qemu-devel@nongnu.org; Thu, 03 Sep 2009 18:18:25 -0400 Received: from an-out-0708.google.com ([209.85.132.250]:43401) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MjKdN-0000AU-Br for qemu-devel@nongnu.org; Thu, 03 Sep 2009 18:18:25 -0400 Received: by an-out-0708.google.com with SMTP id c38so131129ana.37 for ; Thu, 03 Sep 2009 15:18:24 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1252008114.3084.136.camel@blaa> Date: Thu, 3 Sep 2009 19:18:24 -0300 Message-ID: <5d6222a80909031518h2bf804fbk1f7a52424d3e8649@mail.gmail.com> From: Glauber Costa Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [PATCH] qemu-kvm: fix segfault when running kvm without /dev/kvm, falling back to non-accelerated mode List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dustin Kirkland Cc: Mark McLoughlin , qemu-devel@nongnu.org, kvm@vger.kernel.org On Thu, Sep 3, 2009 at 6:48 PM, Dustin Kirkland wro= te: > On Thu, Sep 3, 2009 at 3:01 PM, Mark McLoughlin wrote: >> On Thu, 2009-09-03 at 12:31 -0500, Dustin Kirkland wrote: >>> qemu-kvm: fix segfault when running kvm without /dev/kvm, falling back >>> to non-accelerated mode >>> >>> We're seeing segfaults on systems without access to /dev/kvm. =C2=A0It >>> looks like the global kvm_allowed is being set just a little too late >>> in vl.c. =C2=A0This patch moves the kvm initialization a bit higher in = the >>> vl.c main, just after options processing, and solves the segfaults. >>> We're carrying this patch in Ubuntu 9.10 Alpha. =C2=A0Please apply >>> upstream, or advise if and why this might not be the optimal solution. >> >> Ah discussion about an alternative fix for this fizzled out recently: >> >> =C2=A0http://www.mail-archive.com/kvm@vger.kernel.org/msg19890.html > > Ah, thanks Mark. =C2=A0In that thread, I found Daniel's suggestion the mo= st > reasonable, and user-friendly: > > On Mon, Jul 27, 2009 at 1:44 PM, Daniel P. Berrange = wrote: >> Well, we could go for logic like: >> >> =C2=A0* No arg given =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D> try kvm, try= kqemu, try tcg >> =C2=A0* --accelmode arg given =3D> try $arg, and fail if unavailable >> >> then libvirt would simply always supply --accelmode for all VMs, >> while people running qemu manually would get best available I sent some patches to do that, but they were incomplete, and I was preempted by something else. If you want, you can wait for my cycles to come back, or pick from where I = left --=20 Glauber Costa. "Free as in Freedom" http://glommer.net "The less confident you are, the more serious you have to act."