From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N0bcC-0005cd-7d for qemu-devel@nongnu.org; Wed, 21 Oct 2009 09:52:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N0bcB-0005cH-Nu for qemu-devel@nongnu.org; Wed, 21 Oct 2009 09:52:35 -0400 Received: from [199.232.76.173] (port=37624 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N0bcB-0005cE-Jm for qemu-devel@nongnu.org; Wed, 21 Oct 2009 09:52:35 -0400 Received: from ey-out-1920.google.com ([74.125.78.150]:60254) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N0bcB-0005TG-3H for qemu-devel@nongnu.org; Wed, 21 Oct 2009 09:52:35 -0400 Received: by ey-out-1920.google.com with SMTP id 3so4391994eyh.14 for ; Wed, 21 Oct 2009 06:52:32 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4ADEB7EF.3060800@redhat.com> References: <4ADCE635.4060604@codemonkey.ws> <4ADD9388.8040206@redhat.com> <20091020170800.GG32538@redhat.com> <4ADEB7EF.3060800@redhat.com> Date: Wed, 21 Oct 2009 11:52:32 -0200 Message-ID: <5d6222a80910210652q3b005ca6ub950a2014bfbaa41@mail.gmail.com> Subject: Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM From: Glauber Costa Content-Type: text/plain; charset=UTF-8 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Mulyadi Santosa , qemu-devel@nongnu.org On Wed, Oct 21, 2009 at 5:27 AM, Kevin Wolf wrote: > Am 20.10.2009 19:08, schrieb Daniel P. Berrange: >> On Tue, Oct 20, 2009 at 12:40:08PM +0200, Kevin Wolf wrote: >>> Am 20.10.2009 00:20, schrieb Anthony Liguori: >>>> Mulyadi Santosa wrote: >>>>> IMO, it would be faster if we provide keyboard shortcuts that will >>>>> stop and resume VM execution right from SDL guest interface, rather >>>>> than switching to console monitor first and type "s" or "c" >>>>> respectively. >>>>> >>>> >>>> Is this really common of an operation that you would need an escape key >>>> for it? >>>> >>>> Why are you so frequently stopping and continuing a guest? >>> >>> Why are you all trying to explain to him that actually he doesn't want >>> to have this feature? I could have used it, too, at times (stop the >>> guest to have enough time to attach gdb, for example). There are other >>> ways to do it (although they are not as simple) and I used them, but >>> that doesn't make this feature less useful. >>> >>> Does it take anything away for you? Or do you have plans to use those >>> keys otherwise? If not, why not add a feature that some might find >>> useful, even though others don't? >> >> The problem with adding lots of magic key-sequences, is that the more >> you add, the more likely they are to clash with something that the >> guest OS wants to use. You may make this use case work, but break >> someone else's use case. Thus, IMHO, magic key sequences should be kept >> to the bare minimum neccessary to access functionality for which there >> is no other viable access method. > > Ok, you have a point there. But why do we have key sequences for > fullscreen and resizing the SDL window back to its original size then? > Both are things that could be accessed through monitor commands as well. > And you don't need the right timing for resizing the window - unlike > stopping the VM. So I would be really happy with swapping those for a > "stop VM" shortcut. Why don't we provide a mechanism to make a macro out of a sequence of monitor commands, and let the user assign whatever he wants out of that? -- Glauber Costa. "Free as in Freedom" http://glommer.net "The less confident you are, the more serious you have to act."