From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NF4hg-0000y3-20
	for qemu-devel@nongnu.org; Mon, 30 Nov 2009 06:46:04 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NF4hb-0000wH-Bf
	for qemu-devel@nongnu.org; Mon, 30 Nov 2009 06:46:03 -0500
Received: from [199.232.76.173] (port=57192 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NF4ha-0000w7-Ud
	for qemu-devel@nongnu.org; Mon, 30 Nov 2009 06:45:59 -0500
Received: from mail-pw0-f43.google.com ([209.85.160.43]:36592)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@gmail.com>) id 1NF4ha-0003A4-3k
	for qemu-devel@nongnu.org; Mon, 30 Nov 2009 06:45:58 -0500
Received: by pwi12 with SMTP id 12so2308355pwi.2
	for <qemu-devel@nongnu.org>; Mon, 30 Nov 2009 03:45:57 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4B129425.8090006@redhat.com>
References: <1259256300-23937-1-git-send-email-glommer@redhat.com>
	<1259256300-23937-2-git-send-email-glommer@redhat.com>
	<1259256300-23937-3-git-send-email-glommer@redhat.com>
	<1259256300-23937-4-git-send-email-glommer@redhat.com>
	<1259256300-23937-5-git-send-email-glommer@redhat.com>
	<1259256300-23937-6-git-send-email-glommer@redhat.com>
	<4B129425.8090006@redhat.com>
Date: Mon, 30 Nov 2009 09:45:56 -0200
Message-ID: <5d6222a80911300345w3df34c9bvad12344df484d935@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 5/7] tell kernel about all registers instead
	of just mp_state
From: Glauber Costa <glommer@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Glauber Costa <glommer@redhat.com>, aliguori@us.ibm.com, qemu-devel@nongnu.org

>> since
>> + =C2=A0 =C2=A0 * apic base was just updated
>> + =C2=A0 =C2=A0 */
>> + =C2=A0 =C2=A0kvm_arch_put_registers(s->cpu_env);
>>
>>
>
> Better to use cpu_synchronize_state() instead.
>
I might be misreading it, but :

void kvm_cpu_synchronize_state(CPUState *env)
{
    if (!env->kvm_state->regs_modified) {
        kvm_arch_get_registers(env);
        env->kvm_state->regs_modified =3D 1;
    }
}

Only does get. And we need put.

Glauber  Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."