From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NGAsi-000884-68
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:34:00 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NGAsd-000833-Q1
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:33:59 -0500
Received: from [199.232.76.173] (port=37955 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NGAsd-00082l-HB
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:33:55 -0500
Received: from mail-pw0-f43.google.com ([209.85.160.43]:39908)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@gmail.com>) id 1NGAsd-0000lQ-7n
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:33:55 -0500
Received: by pwi12 with SMTP id 12so1137978pwi.2
	for <qemu-devel@nongnu.org>; Thu, 03 Dec 2009 04:33:54 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4B17ACF9.8030003@redhat.com>
References: <1259761702-4041-1-git-send-email-glommer@redhat.com>
	<1259761702-4041-2-git-send-email-glommer@redhat.com>
	<1259761702-4041-3-git-send-email-glommer@redhat.com>
	<1259761702-4041-4-git-send-email-glommer@redhat.com>
	<1259761702-4041-5-git-send-email-glommer@redhat.com>
	<4B17ACF9.8030003@redhat.com>
Date: Thu, 3 Dec 2009 10:33:54 -0200
Message-ID: <5d6222a80912030433w34220aebv3681724692b9c2a@mail.gmail.com>
Subject: Re: [Qemu-devel] Re: [PATCH 04/11] qemu_flush_work for remote vcpu
	execution
From: Glauber Costa <glommer@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Glauber Costa <glommer@redhat.com>, aliguori@us.ibm.com, qemu-devel@nongnu.org

On Thu, Dec 3, 2009 at 10:20 AM, Avi Kivity <avi@redhat.com> wrote:
> On 12/02/2009 03:48 PM, Glauber Costa wrote:
>>
>> This function is similar to qemu-kvm's on_vcpu mechanism.
>
> Is similar? =C2=A0You're replacing on_vcpu().
Yeah, it began similar, now it is pretty much the same thing, but
using qemu-specific
data structures

>
>> Totally synchronous,
>> and guarantees that a given function will be executed at the specified
>> vcpu.
>>
>> This patch also convert usage within the breakpoints system
>>
>> +void qemu_queue_work(CPUState *env, void (*func)(void *data), void
>> *data);
>>
>
> The name suggests that it is asynchronous.
>
> Why is this patch necessary?

to keep gdbstub working.

>
> --
> error compiling committee.c: too many arguments to function
>
>
>
>



--=20
Glauber  Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."