From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NGAwW-0003Df-Je
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:37:56 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NGAwS-0003AB-Tj
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:37:56 -0500
Received: from [199.232.76.173] (port=36635 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NGAwR-00039p-Ug
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:37:52 -0500
Received: from mail-pz0-f173.google.com ([209.85.222.173]:46164)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <glommer@gmail.com>) id 1NGAwR-0001Ag-CT
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:37:51 -0500
Received: by pzk3 with SMTP id 3so1192251pzk.20
	for <qemu-devel@nongnu.org>; Thu, 03 Dec 2009 04:37:47 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4B17B09B.8030107@redhat.com>
References: <1259761702-4041-1-git-send-email-glommer@redhat.com>
	<1259761702-4041-2-git-send-email-glommer@redhat.com>
	<1259761702-4041-3-git-send-email-glommer@redhat.com>
	<1259761702-4041-4-git-send-email-glommer@redhat.com>
	<1259761702-4041-5-git-send-email-glommer@redhat.com>
	<4B17ACF9.8030003@redhat.com>
	<5d6222a80912030433w34220aebv3681724692b9c2a@mail.gmail.com>
	<4B17B09B.8030107@redhat.com>
Date: Thu, 3 Dec 2009 10:37:47 -0200
Message-ID: <5d6222a80912030437o3be79b67wf88d4c6b275aa526@mail.gmail.com>
Subject: Re: [Qemu-devel] Re: [PATCH 04/11] qemu_flush_work for remote vcpu
	execution
From: Glauber Costa <glommer@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Glauber Costa <glommer@redhat.com>, aliguori@us.ibm.com, qemu-devel@nongnu.org

>
> Keep the name then. =C2=A0The new name is misleading.

ok.

>>>> Totally synchronous,
>>>> and guarantees that a given function will be executed at the specified
>>>> vcpu.
>>>>
>>>> This patch also convert usage within the breakpoints system
>>>>
>>>> +void qemu_queue_work(CPUState *env, void (*func)(void *data), void
>>>> *data);
>>>>
>>>>
>>>
>>> The name suggests that it is asynchronous.
>>>
>>> Why is this patch necessary?
>>>
>>
>> to keep gdbstub working.
>>
>
> "Because it fixes things".
>
> Please elaborate.
>

gdbstub is called from the i/o thread , and call vcpu ioctls. So it
has to use the on_vcpu
mechanism to guarantee its execution in the right thread.

What I meant is that currently, gdbstub is the only user of it, at
least in qemu.git

--=20
Glauber  Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."