From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] hw/timer/Kconfig: Intel 8254 PIT depends of ISA bus
Date: Tue, 7 Jan 2020 09:17:16 +0100 [thread overview]
Message-ID: <5d86fe5c-84a9-5f1f-00df-96e4890533a4@redhat.com> (raw)
In-Reply-To: <20200106171912.16523-1-philmd@redhat.com>
On 06/01/20 18:19, Philippe Mathieu-Daudé wrote:
> Since i8254_common.c calls isa_register_ioport() from "hw/isa/isa.h"
> we can not select it when ISA_BUS is disabled. Add a 'depends on'
> clause.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/timer/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/timer/Kconfig b/hw/timer/Kconfig
> index a990f9fe35..59b3f44d69 100644
> --- a/hw/timer/Kconfig
> +++ b/hw/timer/Kconfig
> @@ -15,6 +15,7 @@ config HPET
>
> config I8254
> bool
> + depends on ISA_BUS
>
> config ALTERA_TIMER
> bool
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2020-01-07 9:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 17:19 [PATCH] hw/timer/Kconfig: Intel 8254 PIT depends of ISA bus Philippe Mathieu-Daudé
2020-01-07 8:17 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d86fe5c-84a9-5f1f-00df-96e4890533a4@redhat.com \
--to=pbonzini@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).