From: Hanna Reitz <hreitz@redhat.com>
To: Emanuele Giuseppe Esposito <eesposit@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Cleber Rosa <crosa@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [PATCH v9 00/16] qemu_iotests: improve debugging options
Date: Tue, 10 Aug 2021 15:53:51 +0200 [thread overview]
Message-ID: <5d8db63d-6df4-98d8-7df9-d087210b907b@redhat.com> (raw)
In-Reply-To: <20210809090114.64834-1-eesposit@redhat.com>
On 09.08.21 11:00, Emanuele Giuseppe Esposito wrote:
> This series adds the option to attach gdbserver and valgrind
> to the QEMU binary running in qemu_iotests.
> It also allows to redirect QEMU binaries output of the python tests
> to the stdout, instead of a log file.
>
> Patches 1-9 introduce the -gdb option to both python and bash tests,
> 10-14 extend the already existing -valgrind flag to work also on
> python tests, and patch 15-16 introduces -p to enable logging to stdout.
>
> In particular, patches 1,6,8,11 focus on extending the QMP socket timers
> when using gdb/valgrind, otherwise the python tests will fail due to
> delays in the QMP responses.
>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
> v9:
> * Replace `! -z` with `-n` in bash scripts (patch 8), and quote $GDB_OPTIONS in
> the same if condition [Max]
> * Add r-b from Max to all patches except 8, remove r-b from Vladimir on patch 8
Thanks! Applied to my block-next branch for 6.2:
https://github.com/XanClic/qemu/commits/block-next
(Usually, I’d take test patches to the block branch regardless of where
we are in the freeze, but with this quite long series I feel better
putting it into block-next.)
Hanna
prev parent reply other threads:[~2021-08-10 13:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 9:00 [PATCH v9 00/16] qemu_iotests: improve debugging options Emanuele Giuseppe Esposito
2021-08-09 9:00 ` [PATCH v9 01/16] python: qemu: add timer parameter for qmp.accept socket Emanuele Giuseppe Esposito
2021-08-09 9:01 ` [PATCH v9 02/16] python: Reduce strictness of pylint's duplicate-code check Emanuele Giuseppe Esposito
2021-08-09 9:01 ` [PATCH v9 03/16] python: qemu: pass the wrapper field from QEMUQtestmachine to QEMUMachine Emanuele Giuseppe Esposito
2021-08-09 9:01 ` [PATCH v9 04/16] docs/devel/testing: add debug section to the QEMU iotests chapter Emanuele Giuseppe Esposito
2021-08-09 9:01 ` [PATCH v9 05/16] qemu-iotests: add option to attach gdbserver Emanuele Giuseppe Esposito
2021-08-09 9:01 ` [PATCH v9 06/16] qemu-iotests: delay QMP socket timers Emanuele Giuseppe Esposito
2021-08-09 9:01 ` [PATCH v9 07/16] qemu_iotests: insert gdbserver command line as wrapper for qemu binary Emanuele Giuseppe Esposito
2021-08-09 9:01 ` [PATCH v9 08/16] qemu-iotests: add gdbserver option to script tests too Emanuele Giuseppe Esposito
2021-08-09 9:01 ` [PATCH v9 09/16] docs/devel/testing: add -gdb option to the debugging section of QEMU iotests Emanuele Giuseppe Esposito
2021-08-09 9:01 ` [PATCH v9 10/16] qemu-iotests: extend the check script to prepare supporting valgrind for python tests Emanuele Giuseppe Esposito
2021-08-09 9:01 ` [PATCH v9 11/16] qemu-iotests: extend QMP socket timeout when using valgrind Emanuele Giuseppe Esposito
2021-08-09 9:01 ` [PATCH v9 12/16] qemu-iotests: allow valgrind to read/delete the generated log file Emanuele Giuseppe Esposito
2021-08-09 9:01 ` [PATCH v9 13/16] qemu-iotests: insert valgrind command line as wrapper for qemu binary Emanuele Giuseppe Esposito
2021-08-09 9:01 ` [PATCH v9 14/16] docs/devel/testing: add -valgrind option to the debug section of QEMU iotests Emanuele Giuseppe Esposito
2021-08-09 9:01 ` [PATCH v9 15/16] qemu-iotests: add option to show qemu binary logs on stdout Emanuele Giuseppe Esposito
2021-08-09 9:01 ` [PATCH v9 16/16] docs/devel/testing: add -p option to the debug section of QEMU iotests Emanuele Giuseppe Esposito
2021-08-10 13:53 ` Hanna Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d8db63d-6df4-98d8-7df9-d087210b907b@redhat.com \
--to=hreitz@redhat.com \
--cc=crosa@redhat.com \
--cc=eesposit@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).