qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: Akihiko Odaki <akihiko.odaki@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Jason Wang <jasowang@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	qemu-devel@nongnu.org, Programmingkid <programmingkidx@gmail.com>
Subject: Re: [PATCH v2 4/4] net: Use bundle mechanism
Date: Sun, 27 Feb 2022 17:23:54 +0100	[thread overview]
Message-ID: <5d952a72-9e1b-919a-a735-3eba89b54146@gmail.com> (raw)
In-Reply-To: <20220226124535.76885-5-akihiko.odaki@gmail.com>

On 26/2/22 13:45, Akihiko Odaki wrote:
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> ---
>   configure         | 1 +
>   include/net/net.h | 2 +-
>   meson.build       | 1 +
>   net/tap.c         | 6 +++++-
>   qemu-options.hx   | 4 ++--
>   5 files changed, 10 insertions(+), 4 deletions(-)

> diff --git a/net/tap.c b/net/tap.c
> index c5cbeaa7a2b..3225d91ae00 100644
> --- a/net/tap.c
> +++ b/net/tap.c
> @@ -508,7 +508,11 @@ static int net_bridge_run_helper(const char *helper, const char *bridge,
>       sigprocmask(SIG_BLOCK, &mask, &oldmask);
>   
>       if (!helper) {
> -        helper = default_helper = get_relocated_path(DEFAULT_BRIDGE_HELPER);
> +        helper = default_helper = find_bundle(DEFAULT_BUNDLE_BRIDGE_HELPER);
> +        if (!helper) {
> +            error_setg(errp, "birdge helper not found");

Typo "bridge".

> +            return -1;
> +        }
>       }


  reply	other threads:[~2022-02-27 16:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-26 12:45 [PATCH v2 0/4] cutils: Introduce bundle mechanism Akihiko Odaki
2022-02-26 12:45 ` [PATCH v2 1/4] " Akihiko Odaki
2022-02-26 12:45 ` [PATCH v2 2/4] datadir: Use " Akihiko Odaki
2022-02-26 12:45 ` [PATCH v2 3/4] ui/icons: " Akihiko Odaki
2022-02-26 12:45 ` [PATCH v2 4/4] net: " Akihiko Odaki
2022-02-27 16:23   ` Philippe Mathieu-Daudé [this message]
2022-02-26 13:02 ` [PATCH v2 0/4] cutils: Introduce " Peter Maydell
2022-02-26 13:09   ` Akihiko Odaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d952a72-9e1b-919a-a735-3eba89b54146@gmail.com \
    --to=philippe.mathieu.daude@gmail.com \
    --cc=akihiko.odaki@gmail.com \
    --cc=jasowang@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=programmingkidx@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).