* [Qemu-devel] [PATCH] util: Adjust qemu_guest_getrandom_nofail for Coverity
@ 2019-05-30 17:38 Richard Henderson
2019-05-31 9:00 ` Peter Maydell
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Richard Henderson @ 2019-05-30 17:38 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, peter.maydell
Explicitly ignore the return value of qemu_guest_getrandom.
Because we use error_fatal, all errors are already caught.
Fixes: CID 1401701
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
util/guest-random.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/guest-random.c b/util/guest-random.c
index e8124a3cad..00a08fd981 100644
--- a/util/guest-random.c
+++ b/util/guest-random.c
@@ -56,7 +56,7 @@ int qemu_guest_getrandom(void *buf, size_t len, Error **errp)
void qemu_guest_getrandom_nofail(void *buf, size_t len)
{
- qemu_guest_getrandom(buf, len, &error_fatal);
+ (void)qemu_guest_getrandom(buf, len, &error_fatal);
}
uint64_t qemu_guest_random_seed_thread_part1(void)
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] util: Adjust qemu_guest_getrandom_nofail for Coverity
2019-05-30 17:38 [Qemu-devel] [PATCH] util: Adjust qemu_guest_getrandom_nofail for Coverity Richard Henderson
@ 2019-05-31 9:00 ` Peter Maydell
2019-05-31 9:44 ` Philippe Mathieu-Daudé
2019-06-06 9:21 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2019-05-31 9:00 UTC (permalink / raw)
To: Richard Henderson; +Cc: QEMU Trivial, QEMU Developers
On Thu, 30 May 2019 at 18:38, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Explicitly ignore the return value of qemu_guest_getrandom.
> Because we use error_fatal, all errors are already caught.
>
> Fixes: CID 1401701
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> util/guest-random.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] util: Adjust qemu_guest_getrandom_nofail for Coverity
2019-05-30 17:38 [Qemu-devel] [PATCH] util: Adjust qemu_guest_getrandom_nofail for Coverity Richard Henderson
2019-05-31 9:00 ` Peter Maydell
@ 2019-05-31 9:44 ` Philippe Mathieu-Daudé
2019-06-06 9:21 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-05-31 9:44 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: qemu-trivial, peter.maydell
On 5/30/19 7:38 PM, Richard Henderson wrote:
> Explicitly ignore the return value of qemu_guest_getrandom.
> Because we use error_fatal, all errors are already caught.
>
> Fixes: CID 1401701
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> util/guest-random.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/guest-random.c b/util/guest-random.c
> index e8124a3cad..00a08fd981 100644
> --- a/util/guest-random.c
> +++ b/util/guest-random.c
> @@ -56,7 +56,7 @@ int qemu_guest_getrandom(void *buf, size_t len, Error **errp)
>
> void qemu_guest_getrandom_nofail(void *buf, size_t len)
> {
> - qemu_guest_getrandom(buf, len, &error_fatal);
> + (void)qemu_guest_getrandom(buf, len, &error_fatal);
> }
>
> uint64_t qemu_guest_random_seed_thread_part1(void)
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] util: Adjust qemu_guest_getrandom_nofail for Coverity
2019-05-30 17:38 [Qemu-devel] [PATCH] util: Adjust qemu_guest_getrandom_nofail for Coverity Richard Henderson
2019-05-31 9:00 ` Peter Maydell
2019-05-31 9:44 ` Philippe Mathieu-Daudé
@ 2019-06-06 9:21 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2019-06-06 9:21 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: qemu-trivial, peter.maydell
Le 30/05/2019 à 19:38, Richard Henderson a écrit :
> Explicitly ignore the return value of qemu_guest_getrandom.
> Because we use error_fatal, all errors are already caught.
>
> Fixes: CID 1401701
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> util/guest-random.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/guest-random.c b/util/guest-random.c
> index e8124a3cad..00a08fd981 100644
> --- a/util/guest-random.c
> +++ b/util/guest-random.c
> @@ -56,7 +56,7 @@ int qemu_guest_getrandom(void *buf, size_t len, Error **errp)
>
> void qemu_guest_getrandom_nofail(void *buf, size_t len)
> {
> - qemu_guest_getrandom(buf, len, &error_fatal);
> + (void)qemu_guest_getrandom(buf, len, &error_fatal);
> }
>
> uint64_t qemu_guest_random_seed_thread_part1(void)
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-06 9:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-30 17:38 [Qemu-devel] [PATCH] util: Adjust qemu_guest_getrandom_nofail for Coverity Richard Henderson
2019-05-31 9:00 ` Peter Maydell
2019-05-31 9:44 ` Philippe Mathieu-Daudé
2019-06-06 9:21 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).