From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Dongli Zhang <dongli.zhang@oracle.com>, qemu-devel@nongnu.org
Cc: armbru@redhat.com, thuth@redhat.com, quintela@redhat.com,
kkostiuk@redhat.com, berrange@redhat.com, dwmw@amazon.co.uk,
pbonzini@redhat.com, joe.jin@oracle.com
Subject: Re: [PATCH v3 1/1] hmp: synchronize cpu state for lapic info
Date: Wed, 8 Nov 2023 11:22:16 +0100 [thread overview]
Message-ID: <5dacc2a2-d087-4f9a-a3b8-400f0539ae62@linaro.org> (raw)
In-Reply-To: <20231026211938.162815-1-dongli.zhang@oracle.com>
On 26/10/23 23:19, Dongli Zhang wrote:
> While the default "info lapic" always synchronizes cpu state ...
>
> mon_get_cpu()
> -> mon_get_cpu_sync(mon, true)
> -> cpu_synchronize_state(cpu)
> -> ioctl KVM_GET_LAPIC (taking KVM as example)
>
> ... the cpu state is not synchronized when the apic-id is available as
> argument.
>
> The cpu state should be synchronized when apic-id is available. Otherwise
> the "info lapic <apic-id>" always returns stale data.
>
> Reference:
> https://lore.kernel.org/all/20211028155457.967291-19-berrange@redhat.com/
>
> Cc: Joe Jin <joe.jin@oracle.com>
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
> ---
> Changed since v1:
> - I sent out wrong patch version in v1
> Changed since v2:
> - Add the Reviewed-by from Daniel and David
>
> target/i386/monitor.c | 5 +++++
> 1 file changed, 5 insertions(+)
Patch queued via my cpu/misc tree, thanks!
prev parent reply other threads:[~2023-11-08 10:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 21:19 [PATCH v3 1/1] hmp: synchronize cpu state for lapic info Dongli Zhang
2023-10-30 16:31 ` Juan Quintela
2023-10-31 22:24 ` Dongli Zhang
2023-11-02 6:00 ` Markus Armbruster
2023-11-06 6:46 ` Thomas Huth
2023-11-08 10:22 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dacc2a2-d087-4f9a-a3b8-400f0539ae62@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dongli.zhang@oracle.com \
--cc=dwmw@amazon.co.uk \
--cc=joe.jin@oracle.com \
--cc=kkostiuk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).