[Qemu-devel] [PATCH] trivial:Loop invariant eode motion in tcg/optimize.c

[Qemu-devel] [PATCH] trivial:Loop invariant eode motion in tcg/optimize.c

[qemu_wanghuang]

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

We find that the "new_base" doesn't change during in the following loop, so we can outer this judgement from this loop.

Signed-off-by: Wanghuang <qemu_wanghuang@126.com>

diff --git a/qemu/tcg/optimize.c b/qemu-local/tcg/optimize.c

index 9c65474..27164f0 100644

--- a/qemu/tcg/optimize.c

+++ b/qemu-local/tcg/optimize.c

@@ -67,12 +67,12 @@ static void reset_temp(TCGArg temp, int nb_temps, int nb_globals)

                 break;

             }

         }

-        for (i = temps[temp].next_copy; i != temp; i = temps[i].next_copy) {

-            if (new_base == (TCGArg)-1) {

+       if (new_base == (TCGArg)-1) {

+           for (i = temps[temp].next_copy; i != temp; i = temps[i].next_copy) 

                 temps[i].state = TCG_TEMP_ANY;

-            } else {

+       } else { 

+          for (i = temps[temp].next_copy; i != temp; i = temps[i].next_copy) 

                 temps[i].val = new_base;

-            }

         }

         temps[temps[temp].next_copy].prev_copy = temps[temp].prev_copy;

         temps[temps[temp].prev_copy].next_copy = temps[temp].next_copy;



[-- Attachment #2: Type: text/html, Size: 2186 bytes --]

Re: [Qemu-devel] [PATCH] trivial:Loop invariant eode motion in tcg/optimize.c

[Peter Maydell]

2011/11/28 qemu_wanghuang <qemu_wanghuang@126.com>:
>------=_Part_169458_1849861657.1322451109855
>Content-Type: text/plain; charset=GBK
>Content-Transfer-Encoding: 7bit
>[...]
>------=_Part_169458_1849861657.1322451109855
>Content-Type: text/html; charset=GBK
>Content-Transfer-Encoding: 7bit

Please don't send patch mails as multipart MIME emails -- they
won't apply cleanly. Plain text as produced by 'git format-patch'
and sent via 'git send-email', please.

-- PMM

Re: [Qemu-devel] [PATCH] trivial:Loop invariant eode motion in tcg/optimize.c

[qemu_wanghuang]

Thank you very much.It's my fault.
At 2011-11-28 16:16:57,"Peter Maydell" <peter.maydell@linaro.org> wrote:
>2011/11/28 qemu_wanghuang <qemu_wanghuang@126.com>:
>>------=_Part_169458_1849861657.1322451109855
>>Content-Type: text/plain; charset=GBK
>>Content-Transfer-Encoding: 7bit
>>[...]
>>------=_Part_169458_1849861657.1322451109855
>>Content-Type: text/html; charset=GBK
>>Content-Transfer-Encoding: 7bit
>
>Please don't send patch mails as multipart MIME emails -- they
>won't apply cleanly. Plain text as produced by 'git format-patch'
>and sent via 'git send-email', please.
>
>-- PMM