Re: [PATCH v4 4/4] QGA VSS: Add log in functions begin/end

[Thomas Huth <thuth@redhat.com>]

On 10/07/2023 09.46, Konstantin Kostiuk wrote:
> Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
> ---
>   qga/vss-win32/install.cpp   | 33 +++++++++++++++++++++++++++++++++
>   qga/vss-win32/provider.cpp  |  3 +++
>   qga/vss-win32/requester.cpp | 34 ++++++++++++++++++++++++++++++++++
>   3 files changed, 70 insertions(+)
> 
> diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
> index 9bd2c52b70..6865c04d8a 100644
> --- a/qga/vss-win32/install.cpp
> +++ b/qga/vss-win32/install.cpp
...
> @@ -175,6 +181,8 @@ out:
>   static HRESULT QGAProviderFind(
>       HRESULT (*found)(ICatalogCollection *, int, void *), void *arg)
>   {
> +    qga_debug_begin;
> +
>       HRESULT hr;
>       COMInitializer initializer;
>       COMPointer<IUnknown> pUnknown;
> @@ -205,12 +213,15 @@ static HRESULT QGAProviderFind(
>       chk(pColl->SaveChanges(&n));
>   
>   out:
> +    qga_debug_end;
>       return hr;
>   }
>   
>   /* Count QGA VSS provider in COM+ Application Catalog */
>   static HRESULT QGAProviderCount(ICatalogCollection *coll, int i, void *arg)
>   {
> +    qga_debug_begin;
> +
>       (*(int *)arg)++;
>       return S_OK;
>   }

Missing gqa_debug_end here?

...
> @@ -277,6 +298,8 @@ VSS_BACKUP_TYPE get_vss_backup_type(
>   
>   void requester_freeze(int *num_vols, void *mountpoints, ErrorSet *errset)
>   {
> +    qga_debug_begin;
> +
>       COMPointer<IVssAsync> pAsync;
>       HANDLE volume;
>       HRESULT hr;
> @@ -292,6 +315,7 @@ void requester_freeze(int *num_vols, void *mountpoints, ErrorSet *errset)
>   
>       if (vss_ctx.pVssbc) { /* already frozen */
>           *num_vols = 0;
> +        qga_debug("finished, already frozen");
>           return;
>       }
>   
> @@ -449,6 +473,7 @@ void requester_freeze(int *num_vols, void *mountpoints, ErrorSet *errset)
>           }
>       }
>   
> +    qga_debug("preparing for backup");
>       hr = vss_ctx.pVssbc->PrepareForBackup(pAsync.replace());
>       if (SUCCEEDED(hr)) {
>           hr = WaitForAsync(pAsync);
> @@ -472,6 +497,7 @@ void requester_freeze(int *num_vols, void *mountpoints, ErrorSet *errset)
>        * CQGAVssProvider::CommitSnapshots will kick vss_ctx.hEventFrozen
>        * after the applications and filesystems are frozen.
>        */
> +    qga_debug("do snapshot set");
>       hr = vss_ctx.pVssbc->DoSnapshotSet(&vss_ctx.pAsyncSnapshot);
>       if (FAILED(hr)) {
>           err_set(errset, hr, "failed to do snapshot set");

You should maybe mention these qga_debug() statements in the commit description.

  Thomas