From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0528DCDB474 for ; Sun, 22 Oct 2023 16:55:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qubj7-0001RY-Rj; Sun, 22 Oct 2023 12:54:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qubiz-0001JK-73 for qemu-devel@nongnu.org; Sun, 22 Oct 2023 12:54:49 -0400 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qubix-00034U-Nt for qemu-devel@nongnu.org; Sun, 22 Oct 2023 12:54:48 -0400 Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-27d11401516so1530506a91.2 for ; Sun, 22 Oct 2023 09:54:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697993685; x=1698598485; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BDw0R8bcPDYhRrIi/2+xqiqr1ikkeKjjUD451Pzb01Y=; b=IU36V1O+ISrmxGnY8m09N1e+98ihvfxQAheBb5akHoHavqmNqwUZkcgRzaoEK9VPm1 dmBC89xPXnkN1tziONzKWpqM3o5BQDbYxHyPuqVWjODvJbEc4RYe42RRCECsvWrgZgnc fBBpNiF2mKs/On9TLL92MxUgnzQUaKCiymFMQmrnTR9ZMatxIbkcoky1l4UtaZ2i1Uct 1uPCjDvY8j8d0kc3k2ioQ1m2Ypf9GcTeDf7NwYYnMzu9wt4UtglyWYR93Cso7sJVhg6E nSpNeM8oANyKAXzvzmRsMMSqwOSvJHstuTnR+F5P8TKigqOd9NtzULiVGzYcSTQu1m4F Zw4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697993685; x=1698598485; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BDw0R8bcPDYhRrIi/2+xqiqr1ikkeKjjUD451Pzb01Y=; b=fezgqZR1X8PClK5hUopV8lGc+B50DGtozSSdmWAYfMeo/8dRkLh7teCxEGZ8yGdYKO iiXHFZq9p9LpGFvATHxOhn7hI/3PIcl6PoknIBTCT7Y3w/k8k0btkN6DS6DjFHm02MR7 iI3RoGGaIvwZPujONl6F0qyq14JkWO5VatSHYC/83OdEoB/lkwKn75FdVs9WuCcKarp/ TfmyTxmhJ1tyeXDQvHlGHlaf7+BKxQmRGkBHtHj0LYX6w4XlJk8ajHDCW+oG8SO9CCq4 w3TiqLX5whpgC1bm8OQAlh5ORh+42dj4cm8het0mI7+kdgOzL2mX+12iJvSKz3lOzltg qvJQ== X-Gm-Message-State: AOJu0YyjLQvR2YhWJ8paTBoC6xuaYwcbvjHbYogHDtpm2Jc7N2BKsKu0 uAR8+Zb9GH8EcH5dL859p52tpw== X-Google-Smtp-Source: AGHT+IHz00TS7Gkce50B1hv/hOgDvBfB18w6UrQ/msny/JljrJGv8hqEr3vNA3ZcziYSTIwe+pFrbg== X-Received: by 2002:a17:90a:d450:b0:27d:c36:e12d with SMTP id cz16-20020a17090ad45000b0027d0c36e12dmr4810344pjb.6.1697993685430; Sun, 22 Oct 2023 09:54:45 -0700 (PDT) Received: from [192.168.0.4] ([71.212.149.95]) by smtp.gmail.com with ESMTPSA id d10-20020a17090a2a4a00b002790ded9c6dsm4934130pjg.31.2023.10.22.09.54.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Oct 2023 09:54:45 -0700 (PDT) Message-ID: <5de741a7-aca6-40e5-916c-25153cbb4fb0@linaro.org> Date: Sun, 22 Oct 2023 09:54:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] hw/char/stm32f2xx_usart: Update IRQ when DR is written Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Hans-Erik Floryd , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , Alistair Francis References: <20231020170009.86870-1-philmd@linaro.org> <20231020170009.86870-4-philmd@linaro.org> From: Richard Henderson In-Reply-To: <20231020170009.86870-4-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1029.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 10/20/23 10:00, Philippe Mathieu-Daudé wrote: > From: Hans-Erik Floryd > > Signed-off-by: Hans-Erik Floryd > [PMD: Split from bigger patch] > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/char/stm32f2xx_usart.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/char/stm32f2xx_usart.c b/hw/char/stm32f2xx_usart.c > index 46e29089bc..74f007591a 100644 > --- a/hw/char/stm32f2xx_usart.c > +++ b/hw/char/stm32f2xx_usart.c > @@ -169,6 +169,7 @@ static void stm32f2xx_usart_write(void *opaque, hwaddr addr, > clear TC by writing 0 to the SR register, so set it again > on each write. */ > s->usart_sr |= USART_SR_TC; > + stm32f2xx_update_irq(s); > } > return; > case USART_BRR: Reviewed-by: Richard Henderson r~