From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E48BDC433E2 for ; Fri, 11 Sep 2020 23:08:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 609C6221F0 for ; Fri, 11 Sep 2020 23:08:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ww4s5iXQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 609C6221F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGs9q-0004Dy-Gg for qemu-devel@archiver.kernel.org; Fri, 11 Sep 2020 19:08:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGs9K-0003go-AR for qemu-devel@nongnu.org; Fri, 11 Sep 2020 19:08:10 -0400 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:38373) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGs9H-00034T-Lf for qemu-devel@nongnu.org; Fri, 11 Sep 2020 19:08:10 -0400 Received: by mail-pl1-x644.google.com with SMTP id c3so1578270plz.5 for ; Fri, 11 Sep 2020 16:08:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FFt5QqvzeNr/MSJoRb5TuXp6VUbt0z1qymt7bCxMVFQ=; b=Ww4s5iXQSXFQtC/eD5tlMcGzuImwdc+Kx/X00VxyhoszeQ5Fo4PQPJ8vzNAtT62rIg ZC/4WaYgCZyzZv3R62se1DZ8wXch1dKk9rmomokcJdQCjwbII/VPI7HUiWY4ZCbK2ScR Ja+EjZZsKUT74Ko6PkpMT/ZnfWpipzuQjohAuiDjfasu/uQB2VAHg8C/vggiAIB4VO/x VB5v7/RJ/VB+56191jeTLiA1q/9Yyva5ywPPPChsZb1yhh90lKBbP1fIO9NXns8jWG8T 0mCGyO33DhTmcAh2jZBjn/IUYMSHSglS4Va+evxdNWk83QfmFw9m4yYmLlDaK6MguycF qKcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FFt5QqvzeNr/MSJoRb5TuXp6VUbt0z1qymt7bCxMVFQ=; b=Hw72y+i0ZCMSplFq1x32BN2mXKru8C7xpeo0NSL4/8R4ZUuMR1tQt4np2ioEQR3LDt C3h7NP2F44qJtdNLnk5HKGOy7q/HdaU8GWGNonvknUTIA3MLhms2svlIZxb9ikTZNSeh VfJaBu7cOoAwNgJcZsYsHkXKYo3bZJO21BRX6NgTif+/TDyHG1+X25YXBYJq70L8uU/3 OK6nPvskMp7Hw/laeXSWL/kml32MZMIEWgb9omeL8WqY2NQNgdr4t2AwHdLIdGj63JU3 dILLzCtSTWU0e7CWN+y19OWNV9y5SL3U3B2hGZOQNcZ5o8qNnuqnavOmmboN7H6EQx6N HsCw== X-Gm-Message-State: AOAM530o9WkhbJKgSqB/VT1Pd393AkTIVDm1LWYzB7biLTAhjbPb1OTQ HKkqq8OpuiEhYsvJDnUR9ahZ+A== X-Google-Smtp-Source: ABdhPJzKUi2SH/U3Xz+cHoQJug1CIDUfbWTLAkeD07yOUACG1J6ODVuYSjGJFfq/PSn0zx1k036Leg== X-Received: by 2002:a17:90a:4cc6:: with SMTP id k64mr4152311pjh.103.1599865686051; Fri, 11 Sep 2020 16:08:06 -0700 (PDT) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id il14sm2700586pjb.54.2020.09.11.16.08.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Sep 2020 16:08:05 -0700 (PDT) Subject: Re: [PATCH 4/7] hw/char/serial: Rename I/O read/write trace events To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20200907015535.827885-1-f4bug@amsat.org> <20200907015535.827885-5-f4bug@amsat.org> From: Richard Henderson Message-ID: <5decc72a-fc28-d2f5-9516-8bb55f2092ce@linaro.org> Date: Fri, 11 Sep 2020 16:08:03 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200907015535.827885-5-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::644; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x644.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -45 X-Spam_score: -4.6 X-Spam_bar: ---- X-Spam_report: (-4.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.469, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , "Michael S. Tsirkin" , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/6/20 6:55 PM, Philippe Mathieu-Daudé wrote: > The serial_mm_read/write() handlers from the TYPE_SERIAL_MM device > call the serial_ioport_read/write() handlers with shifted offset. > > When looking at the trace events from this MMIO device, it is > confusing to read the accesses as I/O. Simplify using generic > trace event names which make sense the various uses. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/char/serial.c | 4 ++-- > hw/char/trace-events | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~