Re: [Qemu-devel] [PATCH v2] tests/qmp-test: Add generic, basic test of query commands

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

On 08/11/2017 09:19 AM, Markus Armbruster wrote:
> A command is a query if it has no side effect and yields a result.
> Such commands are typically named query-FOO, but there are exceptions.
> 
> The basic idea is to find candidates with query-qmp-schema, filter out
> the ones that aren't queries with an explicit blacklist, and test the
> remaining ones against a QEMU with no special arguments.
> 

> ---
> v2:
> * Make the test pass for all targets (note to self: do not post
>   patches after dark)
> * Tighten the test for query-spice, query-xen-replication-status:
>   expect failure only when they are stubs
> * Don't blacklist query-acpi-ospm-status and query-hotpluggable-cpus;
>   they fail reliably

Indeed, looks like quite a few changes.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]