From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bin Meng <bin.meng@windriver.com>, qemu-devel@nongnu.org
Cc: Alistair Francis <alistair@alistair23.me>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
Peter Maydell <peter.maydell@linaro.org>,
Radoslaw Biernacki <rad@semihalf.com>,
qemu-arm@nongnu.org
Subject: Re: [PATCH 1/3] hw/arm: Refactor struct arm_boot_info::get_dtb()
Date: Mon, 15 Jan 2024 12:06:58 +0100 [thread overview]
Message-ID: <5e0b0da5-c737-41c4-9c8e-52450ca14af3@linaro.org> (raw)
In-Reply-To: <20240115043431.3900922-2-bin.meng@windriver.com>
On 15/1/24 05:34, Bin Meng wrote:
> At present we expect struct arm_boot_info::get_dtb() to return the
> device tree pointer as well as the device tree size. However, this
> is not necessary as we can get the device tree size via the device
> tree header directly. Change get_dtb() signature to drop the *size
> argument, and get the size by ourselves.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
>
> include/hw/arm/boot.h | 8 ++++----
> hw/arm/boot.c | 3 ++-
> hw/arm/sbsa-ref.c | 3 +--
> hw/arm/virt.c | 4 +---
> hw/arm/xlnx-versal-virt.c | 4 +---
> 5 files changed, 9 insertions(+), 13 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-01-15 11:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 4:34 [PATCH 0/3] hw/arm: Pack the QEMU generated device tree Bin Meng
2024-01-15 4:34 ` [PATCH 1/3] hw/arm: Refactor struct arm_boot_info::get_dtb() Bin Meng
2024-01-15 11:06 ` Philippe Mathieu-Daudé [this message]
2024-01-22 3:26 ` Alistair Francis
2024-01-15 4:34 ` [PATCH 2/3] hw/arm: Pack the QEMU generated device tree Bin Meng
2024-01-19 14:17 ` Peter Maydell
2024-01-15 4:34 ` [PATCH 3/3] tests/acpi: Update virt/SSDT.memhp Bin Meng
2024-01-15 11:39 ` Alex Bennée
2024-01-15 14:46 ` Bin Meng
2024-01-15 19:07 ` Laszlo Ersek
2024-01-19 14:29 ` Peter Maydell
2024-01-19 17:19 ` Laszlo Ersek
2024-01-19 17:46 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e0b0da5-c737-41c4-9c8e-52450ca14af3@linaro.org \
--to=philmd@linaro.org \
--cc=alistair@alistair23.me \
--cc=bin.meng@windriver.com \
--cc=edgar.iglesias@gmail.com \
--cc=marcin.juszkiewicz@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=rad@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).