From: Paolo Bonzini <pbonzini@redhat.com>
To: Auger Eric <eric.auger@redhat.com>, Peter Xu <peterx@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>, Yan Zhao <yan.y.zhao@intel.com>,
qemu-devel@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap
Date: Mon, 24 Jun 2019 15:21:12 +0200 [thread overview]
Message-ID: <5e0bacfa-a9aa-5f05-b889-47bc6a5fb295@redhat.com> (raw)
In-Reply-To: <6805f941-55b9-93d9-fbbf-a922e55b5cfe@redhat.com>
On 24/06/19 14:48, Auger Eric wrote:
>>>> + if (alignment <= size) {
>>>> + /* Increase the alignment of start */
>>> I don't really get this comment
>> This comment comes from Paolo, but I'll try to explain - it tries to
>> mean that this "alignment" will be used as an increasement to "start"
>> variable, so finally variable "start" will align with larger mask
>> size.
>>
>> Better comments welcomed... :)
> smallest page mask from @start or gaw?
What it means is that there will be "more 0 bits" at the beginning of
start. Perhaps "On the next iteration start will be aligned to a bigger
power of two"? I can do this when applying.
Paolo
next prev parent reply other threads:[~2019-06-24 13:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 9:18 [Qemu-devel] [PATCH v2 0/2] intel_iommu: Fix unexpected unmaps during global unmap Peter Xu
2019-06-24 9:18 ` [Qemu-devel] [PATCH v2 1/2] intel_iommu: Fix incorrect "end" for vtd_address_space_unmap Peter Xu
2019-07-04 5:39 ` Jason Wang
2019-06-24 9:18 ` [Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap Peter Xu
2019-06-24 10:09 ` Auger Eric
2019-06-24 11:10 ` Peter Xu
2019-06-24 12:48 ` Auger Eric
2019-06-24 13:21 ` Paolo Bonzini [this message]
2019-06-24 10:12 ` Paolo Bonzini
2019-06-25 3:02 ` Yan Zhao
2019-06-25 7:00 ` Auger Eric
2019-07-04 5:45 ` Jason Wang
2019-07-04 8:17 ` Peter Xu
2019-07-01 12:00 ` [Qemu-devel] [PATCH v2 0/2] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e0bacfa-a9aa-5f05-b889-47bc6a5fb295@redhat.com \
--to=pbonzini@redhat.com \
--cc=eric.auger@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).