Re: [PATCH 2/2] system/vl.c: parse all -accel options

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 1/7/24 15:30, Daniel Henrique Barboza wrote:
> We're not honouring KVM options that are provided by any -accel option
> aside from the first. In this example:
> 
> qemu-system-riscv64 -accel kvm,riscv-aia=emul (...) \ -accel
> kvm,riscv-aia=hwaccel
> 
> 'riscv-aia' will be set to 'emul', ignoring the last occurrence of the
> option that set 'riscv-aia' to 'hwaccel'.
> 
> The previous change guarantees that we'll not have mixed accelerators in
> the command line, and now it's safe to activate 'merge_lists' for
> 'qemu_accel_opts'. This will merge all accel options in the same list,
> allowing the 'qemu_opt_foreach()' callback in do_configure_accelerator()
> to apply each one of them in the Accel class.
> 
> Reported-by: Andrew Jones <ajones@ventanamicro.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> ---
>   system/vl.c | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>