From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Titus Rwantare <titusr@google.com>
Cc: peter.maydell@linaro.org, minyard@acm.org, qemu-arm@nongnu.org,
qemu-devel@nongnu.org, venture@google.com, wuhaotsh@google.com
Subject: Re: [PATCH] hw/arm: add Quanta GSZ bmc machine
Date: Mon, 07 Oct 2024 20:16:39 +0100 [thread overview]
Message-ID: <5e176ecece460f8676184b51ef4b3227@codethink.co.uk> (raw)
In-Reply-To: <20241007171700.1594342-1-titusr@google.com>
On 2024-10-07 18:17, Titus Rwantare wrote:
> This patch adds the quanta-gsz-bmc target, a current Google machine of
> the day. This machine will be used as a platform to enable features
> such
> as the PECI bmc interface, and Intel eSPI virtual wire interface in
> QEMU.
>
> Signed-off-by: Titus Rwantare <titusr@google.com>
> ---
> hw/arm/npcm7xx_boards.c | 140 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 140 insertions(+)
>
> diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c
> index e229efb447..e1ff5af756 100644
> --- a/hw/arm/npcm7xx_boards.c
> +++ b/hw/arm/npcm7xx_boards.c
> @@ -48,6 +48,8 @@
> #define NPCM750_EVB_POWER_ON_STRAPS ( \
> NPCM7XX_POWER_ON_STRAPS_DEFAULT & ~NPCM7XX_PWRON_STRAP_J2EN)
> #define QUANTA_GSJ_POWER_ON_STRAPS NPCM7XX_POWER_ON_STRAPS_DEFAULT
> +#define QUANTA_GSZ_POWER_ON_STRAPS ( \
> + NPCM7XX_POWER_ON_STRAPS_DEFAULT & ~NPCM7XX_PWRON_STRAP_SFAB)
> #define QUANTA_GBS_POWER_ON_STRAPS ( \
> NPCM7XX_POWER_ON_STRAPS_DEFAULT & ~NPCM7XX_PWRON_STRAP_SFAB)
> #define KUDO_BMC_POWER_ON_STRAPS NPCM7XX_POWER_ON_STRAPS_DEFAULT
> @@ -269,6 +271,109 @@ static void quanta_gsj_fan_init(NPCM7xxMachine
> *machine, NPCM7xxState *soc)
> npcm7xx_connect_pwm_fan(soc, &splitter[2], 0x05, 1);
> }
>
> +static void quanta_gsz_i2c_init(NPCM7xxState *soc)
> +{
> + I2CSlave *i2c_mux;
> +
> + /* i2c1 */
> + i2c_mux = i2c_slave_create_simple(npcm7xx_i2c_get_bus(soc, 1),
> TYPE_PCA9548,
> + 0x75);
> + /* pca6416@0x20 */
> +
> + i2c_mux = i2c_slave_create_simple(npcm7xx_i2c_get_bus(soc, 1),
> + TYPE_PCA9548, 0x77);
> +
> + i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 0),
> "raa229004", 0x72);
> + i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 1),
> "raa229004", 0x72);
> + i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 2),
> "isl69260", 0x72);
> + i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 3),
> "isl69260", 0x72);
> + i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 4),
> "isl69260", 0x72);
> + i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 5),
> "isl69260", 0x72);
> + i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 6),
> "adm1272", 0x1f);
> +
> + /* i2c2 */
> + i2c_mux = i2c_slave_create_simple(npcm7xx_i2c_get_bus(soc, 2),
> + TYPE_PCA9548, 0x77);
> + /* - channel 0: tps546d24 @25
> + * - channel 1: delta,dps800 @69
> + */
> + i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 1),
> "raa228000", 0x68);
> + /* - channel 2: delta,dps800 @68 */
> + /* max31725 is compatible with tmp105. */
> + i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 4), "tmp105",
> 0x5c);
> + i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 5), "tmp105",
> 0x5c);
> + i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 6), "tmp105",
> 0x5c);
> +
> + /* i2c3 */
> + i2c_mux = i2c_slave_create_simple(npcm7xx_i2c_get_bus(soc, 3),
> TYPE_PCA9548,
> + 0x77);
> +
> + /* i2c4 */
> + /* mobo_fru_1 */
> + at24c_eeprom_init(npcm7xx_i2c_get_bus(soc, 4), 0x50, 8192);
> + i2c_mux = i2c_slave_create_simple(npcm7xx_i2c_get_bus(soc, 4),
> + TYPE_PCA9548, 0x77);
> + i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 0),
> "max34451", 0x59);
> + /* mobo_fru_2 */
> + at24c_eeprom_init(npcm7xx_i2c_get_bus(soc, 2), 0x55, 32768);
> +
> + /* pca6416@0x20 */
> + /* pca6416@0x20 */
> +
> + /* pdb_fru */
> + at24c_eeprom_init(npcm7xx_i2c_get_bus(soc, 6), 0x55, 8192);
> +
> + /* i2c5 */
> + i2c_mux = i2c_slave_create_simple(npcm7xx_i2c_get_bus(soc, 5),
> TYPE_PCA9548,
> + 0x77);
> +
> + /* i2c6 */
> + i2c_mux = i2c_slave_create_simple(npcm7xx_i2c_get_bus(soc, 6),
> TYPE_PCA9548,
> + 0x77);
> +
> + /* i2c7 */
> + i2c_mux = i2c_slave_create_simple(npcm7xx_i2c_get_bus(soc, 7),
> TYPE_PCA9548,
> + 0x77);
> +
> + /* i2c8 */
> + i2c_mux = i2c_slave_create_simple(npcm7xx_i2c_get_bus(soc, 8),
> TYPE_PCA9548,
> + 0x77);
> +
> + /* i2c9 */
> + i2c_mux = i2c_slave_create_simple(npcm7xx_i2c_get_bus(soc, 9),
> TYPE_PCA9548,
> + 0x77);
> +
> + /* i2c10 */
> + i2c_mux = i2c_slave_create_simple(npcm7xx_i2c_get_bus(soc, 10),
> + TYPE_PCA9548, 0x77);
> +
> + /* i2c11 */
> + i2c_mux = i2c_slave_create_simple(npcm7xx_i2c_get_bus(soc, 11),
> + TYPE_PCA9548, 0x77);
> +
> + /* i2c12 */
> +
A for () loop to create these devices would be good.
> + /* i2c13 */
> + /* pca9555@22 */
> +
> + /* i2c14 */
> + /* LEDs and PE Resets */
> + /* pca6416@0x20 */
> +
> + /* bmc_fru_1 */
> + at24c_eeprom_init(npcm7xx_i2c_get_bus(soc, 14), 0x55, 8192);
> +
> + i2c_mux = i2c_slave_create_simple(npcm7xx_i2c_get_bus(soc, 14),
> + TYPE_PCA9548, 0x77);
> + i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 0),
> "max34451", 0x59);
> +
> + /* max31725 is compatible with tmp105 */
> + i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 4), "tmp105",
> 0x5c);
> +
> + /* i2c15 */
> + i2c_slave_create_simple(npcm7xx_i2c_get_bus(soc, 15),
> TYPE_PCA9546, 0x75);
> +}
> +
> static void quanta_gbs_i2c_init(NPCM7xxState *soc)
> {
> /*
> @@ -392,6 +497,25 @@ static void quanta_gsj_init(MachineState *machine)
> npcm7xx_load_kernel(machine, soc);
>
next prev parent reply other threads:[~2024-10-07 19:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 17:17 [PATCH] hw/arm: add Quanta GSZ bmc machine Titus Rwantare
2024-10-07 19:16 ` Ben Dooks [this message]
2024-10-07 20:16 ` Titus Rwantare
2024-10-18 15:41 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e176ecece460f8676184b51ef4b3227@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=minyard@acm.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=titusr@google.com \
--cc=venture@google.com \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).