Re: [Qemu-devel] [PATCH 1/9] net: Introduce announce timer

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]

On 1/28/19 11:03 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> The 'announce timer' will be used by migration, and explicit
> requests for qemu to perform network announces.
> 
> Based on the work by Germano Veit Michel <germano@redhat.com>
>  and Vlad Yasevich <vyasevic@redhat.com>
> 
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---

> +++ b/qapi/net.json
> @@ -684,3 +684,26 @@
>  ##
>  { 'event': 'NIC_RX_FILTER_CHANGED',
>    'data': { '*name': 'str', 'path': 'str' } }
> +
> +##
> +# @AnnounceParameters:
> +#
> +# Parameters for self-announce timers
> +#
> +# @initial: Initial delay (in ms) before sending the first GARP/RARP
> +#       announcement
> +#
> +# @max: Maximum delay (in ms) to between GARP/RARP announcement packets

"to between" should be either "to use in between" or merely "between"

> +#
> +# @rounds: Number of self-announcement attempts
> +#
> +# @step: Delay increase (in ms) after each self-announcement attempt
> +#
> +# Since: 4.0
> +##
> +
> +{ 'struct': 'AnnounceParameters',
> +  'data': { 'initial': 'int',
> +            'max': 'int',
> +            'rounds': 'int',
> +            'step': 'int' } }
> 

Can/should any of the parameters be optional with a sane (documented)
default?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]