qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: jasowang@redhat.com, Anthony Liguori <anthony@codemonkey.ws>,
	qemu-devel@nongnu.org, quintela@redhat.com
Subject: [Qemu-devel] [PATCHv2 3/6] migration/savevm: no need to flush requests
Date: Wed, 24 Nov 2010 17:53:02 +0200	[thread overview]
Message-ID: <5e41c7e3293678809cb901185bd9393d0976c614.1290613959.git.mst@redhat.com> (raw)
In-Reply-To: <cover.1290613959.git.mst@redhat.com>

There's no need to flush requests after vmstop
as vmstop does it for us automatically now.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Jason Wang <jasowang@redhat.com>
---
 migration.c |    2 --
 savevm.c    |    4 ----
 2 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/migration.c b/migration.c
index 9ee8b17..15f7f35 100644
--- a/migration.c
+++ b/migration.c
@@ -368,8 +368,6 @@ void migrate_fd_put_ready(void *opaque)
         DPRINTF("done iterating\n");
         vm_stop(0);
 
-        qemu_aio_flush();
-        bdrv_flush_all();
         if ((qemu_savevm_state_complete(s->mon, s->file)) < 0) {
             if (old_vm_running) {
                 vm_start();
diff --git a/savevm.c b/savevm.c
index 4e49765..49e78a5 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1575,8 +1575,6 @@ static int qemu_savevm_state(Monitor *mon, QEMUFile *f)
     saved_vm_running = vm_running;
     vm_stop(0);
 
-    bdrv_flush_all();
-
     ret = qemu_savevm_state_begin(mon, f, 0, 0);
     if (ret < 0)
         goto out;
@@ -1885,8 +1883,6 @@ void do_savevm(Monitor *mon, const QDict *qdict)
         monitor_printf(mon, "No block device can accept snapshots\n");
         return;
     }
-    /* ??? Should this occur after vm_stop?  */
-    qemu_aio_flush();
 
     saved_vm_running = vm_running;
     vm_stop(0);
-- 
1.7.3.2.91.g446ac

  parent reply	other threads:[~2010-11-24 16:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-24 15:52 [Qemu-devel] [PATCHv2 0/6] stable migration image on a stopped vm Michael S. Tsirkin
2010-11-24 15:52 ` [Qemu-devel] [PATCHv2 1/6] virtio-net: don't dma while vm is stopped Michael S. Tsirkin
2010-11-24 15:52 ` [Qemu-devel] [PATCHv2 2/6] cpus: flush all requests on each vm stop Michael S. Tsirkin
2010-11-30 12:45   ` Marcelo Tosatti
2010-11-30 13:14     ` Michael S. Tsirkin
2010-11-30 13:34     ` Michael S. Tsirkin
2010-11-30 13:46       ` Marcelo Tosatti
2010-11-30 14:05         ` Michael S. Tsirkin
2010-12-03 16:30           ` Marcelo Tosatti
2010-11-24 15:53 ` Michael S. Tsirkin [this message]
2010-11-24 15:53 ` [Qemu-devel] [PATCHv2 4/6] virtio-net: stop/start bh on vm start/stop Michael S. Tsirkin
2010-11-29 15:37   ` [Qemu-devel] [PATCHv3 4/6] virtio-net: stop/start bh when appropriate Michael S. Tsirkin
2010-12-01  5:45     ` Jason Wang
2010-12-01  5:59       ` Michael S. Tsirkin
2010-12-03  8:40         ` Kevin Wolf
2010-12-01  6:02       ` Michael S. Tsirkin
2010-12-01  6:17         ` Jason Wang
2010-12-02 12:56         ` Jason Wang
2010-12-02 13:07           ` Michael S. Tsirkin
2010-12-02 13:08           ` Michael S. Tsirkin
2010-12-02 14:19             ` Jason Wang
2010-12-02 15:38               ` Michael S. Tsirkin
2010-12-03 13:32                 ` Jason Wang
2010-12-02 18:27               ` Michael S. Tsirkin
2010-12-03  8:39                 ` Kevin Wolf
2010-11-24 15:53 ` [Qemu-devel] [PATCHv2 5/6] migration: stable ram block ordering Michael S. Tsirkin
2010-11-24 15:53 ` [Qemu-devel] [PATCHv2 6/6] migration: allow rate > 4g Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e41c7e3293678809cb901185bd9393d0976c614.1290613959.git.mst@redhat.com \
    --to=mst@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).