From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH] target/s390x: Optimize save_link_info() using extract() TCG opcode
Date: Sun, 3 Oct 2021 11:31:47 -0400 [thread overview]
Message-ID: <5e484c8f-23be-9162-7fcc-97528e25b830@linaro.org> (raw)
In-Reply-To: <20211003142922.3678039-1-f4bug@amsat.org>
On 10/3/21 10:29 AM, Philippe Mathieu-Daudé wrote:
> - tcg_gen_shri_i64(t, psw_mask, 16);
> - tcg_gen_andi_i64(t, t, 0x0f000000);
> + tcg_gen_extract_i64(t, psw_mask, 40, 4);
No, the result should not be at bit 0, but bit 24.
r~
next prev parent reply other threads:[~2021-10-03 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 14:29 [PATCH] target/s390x: Optimize save_link_info() using extract() TCG opcode Philippe Mathieu-Daudé
2021-10-03 15:31 ` Richard Henderson [this message]
2021-10-03 15:51 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e484c8f-23be-9162-7fcc-97528e25b830@linaro.org \
--to=richard.henderson@linaro.org \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).