From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org,
qemu-s390x@nongnu.org
Subject: Re: [PATCH 00/16] overall: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check
Date: Fri, 10 Oct 2025 15:51:40 +0200 [thread overview]
Message-ID: <5e4d3a1a-ee13-40c3-b470-d68f5b6b4ad1@redhat.com> (raw)
In-Reply-To: <20251010134226.72221-1-philmd@linaro.org>
On 10/10/25 15:42, Philippe Mathieu-Daudé wrote:
> Replace compile-time #ifdef with a runtime check to ensure all code
> paths are built and tested. This reduces build-time configuration
> complexity and improves maintainability.
>
> No functional change intended.
No need to repost (and I didn't review), but please change throughout
the commit message to mention a *compile-time* if() check. The code for
the wrong endianness will not make it past compilation, and mentioning
runtime checks left me wondering if you had mistaken HOST for TARGET.
Thanks,
Paolo
> Philippe Mathieu-Daudé (16):
> linux-user/arm: Checkpatch style cleanups
> linux-user/arm: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check
> ui: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check
> net: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check
> disas: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check
> hw/core/loader: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check
> hw/display: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check
> hw/virtio: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check
> target/alpha: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check
> target/arm: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check
> target/mips: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check
> target/ppc: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check
> target/riscv: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check
> target/s390x: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check
> target/sparc: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check
> util/bitmap: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check
>
> include/hw/virtio/virtio-access.h | 6 +-
> include/hw/virtio/virtio-gpu-bswap.h | 6 +-
> target/arm/cpu.h | 8 +-
> target/arm/tcg/translate-a64.h | 5 +-
> disas/disas-host.c | 6 +-
> hw/core/loader.c | 5 +-
> hw/display/artist.c | 12 +-
> hw/display/vga.c | 20 +-
> hw/display/virtio-gpu-gl.c | 8 +-
> hw/display/virtio-gpu-rutabaga.c | 8 +-
> hw/virtio/vhost.c | 7 +-
> linux-user/arm/nwfpe/double_cpdo.c | 12 +-
> linux-user/arm/nwfpe/fpa11_cpdt.c | 77 +-
> net/net.c | 14 +-
> target/alpha/translate.c | 11 +-
> target/arm/tcg/sve_helper.c | 10 +-
> target/arm/tcg/translate-sve.c | 22 +-
> target/arm/tcg/translate-vfp.c | 8 +-
> target/arm/tcg/translate.c | 6 +-
> target/mips/tcg/msa_helper.c | 889 ++++++++++++------------
> target/ppc/arch_dump.c | 9 +-
> target/ppc/int_helper.c | 28 +-
> target/ppc/kvm.c | 25 +-
> target/riscv/vector_helper.c | 32 +-
> target/s390x/tcg/translate.c | 6 +-
> target/sparc/vis_helper.c | 18 +-
> ui/vdagent.c | 16 +-
> ui/vnc.c | 6 +-
> util/bitmap.c | 19 +-
> target/ppc/translate/vmx-impl.c.inc | 14 +-
> target/ppc/translate/vsx-impl.c.inc | 6 +-
> target/riscv/insn_trans/trans_rvv.c.inc | 16 +-
> target/s390x/tcg/translate_vx.c.inc | 6 +-
> tcg/ppc/tcg-target.c.inc | 24 +-
> 34 files changed, 656 insertions(+), 709 deletions(-)
>
next prev parent reply other threads:[~2025-10-10 13:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 13:42 [PATCH 00/16] overall: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check Philippe Mathieu-Daudé
2025-10-10 13:42 ` [PATCH 01/16] linux-user/arm: Checkpatch style cleanups Philippe Mathieu-Daudé
2025-10-10 13:42 ` [PATCH 02/16] linux-user/arm: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check Philippe Mathieu-Daudé
2025-10-10 13:42 ` [PATCH 03/16] ui: " Philippe Mathieu-Daudé
2025-10-13 11:57 ` Marc-André Lureau
2025-10-10 13:42 ` [PATCH 04/16] net: " Philippe Mathieu-Daudé
2025-10-10 13:42 ` [PATCH 05/16] disas: " Philippe Mathieu-Daudé
2025-10-10 13:42 ` [PATCH 06/16] hw/core/loader: " Philippe Mathieu-Daudé
2025-10-10 13:42 ` [PATCH 07/16] hw/display: " Philippe Mathieu-Daudé
2025-10-10 13:42 ` [PATCH 08/16] hw/virtio: " Philippe Mathieu-Daudé
2025-10-10 19:23 ` Farhan Ali
2025-10-11 8:04 ` Lei Yang
2025-10-10 13:42 ` [PATCH 09/16] target/alpha: " Philippe Mathieu-Daudé
2025-10-10 13:42 ` [PATCH 10/16] target/arm: " Philippe Mathieu-Daudé
2025-10-10 13:42 ` [PATCH 11/16] target/mips: " Philippe Mathieu-Daudé
2025-10-10 13:42 ` [PATCH 12/16] target/ppc: " Philippe Mathieu-Daudé
2025-10-10 13:42 ` [PATCH 13/16] target/riscv: " Philippe Mathieu-Daudé
2025-10-10 13:42 ` [PATCH 14/16] target/s390x: " Philippe Mathieu-Daudé
2025-10-10 13:56 ` David Hildenbrand
2025-10-10 13:42 ` [PATCH 15/16] target/sparc: " Philippe Mathieu-Daudé
2025-10-10 13:42 ` [PATCH 16/16] util/bitmap: " Philippe Mathieu-Daudé
2025-10-10 13:51 ` Paolo Bonzini [this message]
2025-10-10 14:37 ` [PATCH 00/16] overall: " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e4d3a1a-ee13-40c3-b470-d68f5b6b4ad1@redhat.com \
--to=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).