From: Richard Henderson <richard.henderson@linaro.org>
To: Karim Taha <kariem.taha2.7@gmail.com>, qemu-devel@nongnu.org
Cc: imp@bsdimp.com, Michal Meloun <mmel@FreeBSD.org>
Subject: Re: [PATCH 07/33] Add struct target_stat to bsd-user/syscall_defs.h
Date: Tue, 8 Aug 2023 14:21:59 -0700 [thread overview]
Message-ID: <5e757317-35c3-634a-a6dd-1ac267a2bf67@linaro.org> (raw)
In-Reply-To: <20230808060815.9001-8-kariem.taha2.7@gmail.com>
On 8/7/23 23:07, Karim Taha wrote:
> +struct target_stat {
> + uint64_t st_dev; /* inode's device */
> + uint64_t st_ino; /* inode's number */
> + uint64_t st_nlink; /* number of hard links */
Indentation of 8 instead of 4.
Otherwise,
Acked-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-08-08 21:22 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 6:07 [PATCH 00/33] Implement the stat system calls for FreeBSD Karim Taha
2023-08-08 6:07 ` [PATCH 01/33] Move _WANT_FREEBSD macros to include/qemu/osdep.h Karim Taha
2023-08-08 20:45 ` Richard Henderson
2023-08-08 6:07 ` [PATCH 02/33] Disable clang warnings arising from bsd-user/qemu.h Karim Taha
2023-08-08 20:50 ` Richard Henderson
2023-08-09 2:56 ` Warner Losh
2023-08-09 3:05 ` Richard Henderson
2023-08-09 3:08 ` Warner Losh
2023-08-08 6:07 ` [PATCH 03/33] Update the definitions of __put_user and __get_user macros Karim Taha
2023-08-08 21:03 ` Richard Henderson
2023-08-09 1:39 ` Warner Losh
2023-08-09 1:47 ` Richard Henderson
2023-08-09 2:41 ` Warner Losh
2023-08-09 3:06 ` Richard Henderson
2023-08-08 6:07 ` [PATCH 04/33] Declarations of h2t and t2h conversion functions Karim Taha
2023-08-08 21:17 ` Richard Henderson
2023-08-08 6:07 ` [PATCH 05/33] Forward declare functions defined in os-stat.c Karim Taha
2023-08-08 21:19 ` Richard Henderson
2023-08-08 6:07 ` [PATCH 06/33] Add struct target_freebsd11_stat to bsd-user/syscall_defs Karim Taha
2023-08-08 21:21 ` Richard Henderson
2023-08-08 21:23 ` Richard Henderson
2023-08-09 2:43 ` Warner Losh
2023-08-08 6:07 ` [PATCH 07/33] Add struct target_stat to bsd-user/syscall_defs.h Karim Taha
2023-08-08 21:21 ` Richard Henderson [this message]
2023-08-08 6:07 ` [PATCH 08/33] Add structs target_freebsd11_nstat and target_freebsd11_statfs " Karim Taha
2023-08-08 21:24 ` Richard Henderson
2023-08-09 2:51 ` Warner Losh
2023-08-09 3:12 ` Richard Henderson
2023-08-09 4:41 ` Warner Losh
2023-08-09 5:05 ` Warner Losh
2023-08-08 6:07 ` [PATCH 09/33] Add struct target_statfs " Karim Taha
2023-08-08 21:25 ` Richard Henderson
2023-08-08 6:07 ` [PATCH 10/33] Add struct target_freebsd_fhandle and fcntl flags " Karim Taha
2023-08-08 21:26 ` Richard Henderson
2023-08-09 2:54 ` Warner Losh
2023-08-08 6:07 ` [PATCH 11/33] Define safe_fcntl macro in bsd-user/syscall_defs.h Karim Taha
2023-08-08 21:27 ` Richard Henderson
2023-08-08 6:07 ` [PATCH 12/33] Rename target_freebsd_time_t to target_time_t Karim Taha
2023-08-08 21:28 ` Richard Henderson
2023-08-08 6:07 ` [PATCH 13/33] Implement host-target convertion functions Karim Taha
2023-08-08 21:30 ` Richard Henderson
2023-08-08 21:31 ` Richard Henderson
2023-08-08 6:07 ` [PATCH 14/33] " Karim Taha
2023-08-08 21:34 ` Richard Henderson
2023-08-08 6:07 ` [PATCH 15/33] " Karim Taha
2023-08-08 21:36 ` Richard Henderson
2023-08-08 6:07 ` [PATCH 16/33] " Karim Taha
2023-08-08 21:39 ` Richard Henderson
2023-08-09 3:01 ` Warner Losh
2023-08-08 6:07 ` [PATCH 17/33] Implement h2t_freebsd_stat and h2t_freebsd_statfs functions Karim Taha
2023-08-08 21:40 ` Richard Henderson
2023-08-08 6:08 ` [PATCH 18/33] Implement stat related syscalls Karim Taha
2023-08-08 21:53 ` Richard Henderson
2023-08-09 3:07 ` Warner Losh
2023-08-09 3:17 ` Richard Henderson
2023-08-08 6:08 ` [PATCH 19/33] " Karim Taha
2023-08-08 6:08 ` [PATCH 20/33] " Karim Taha
2023-08-08 6:08 ` [PATCH 21/33] " Karim Taha
2023-08-08 6:08 ` [PATCH 22/33] " Karim Taha
2023-08-08 6:08 ` [PATCH 23/33] Implement freebsd11 " Karim Taha
2023-08-08 6:08 ` [PATCH 24/33] " Karim Taha
2023-08-08 6:08 ` [PATCH 25/33] " Karim Taha
2023-08-08 6:08 ` [PATCH 26/33] " Karim Taha
2023-08-08 6:08 ` [PATCH 27/33] " Karim Taha
2023-08-08 6:08 ` [PATCH 28/33] Implement do_freebsd_realpathat syscall Karim Taha
2023-08-08 6:08 ` [PATCH 29/33] Add os-stat.c to the build Karim Taha
2023-08-08 6:08 ` [PATCH 30/33] Add glue to call the following syscalls to the freebsd_syscall function: Karim Taha
2023-08-08 6:08 ` [PATCH 31/33] " Karim Taha
2023-08-08 6:08 ` [PATCH 32/33] " Karim Taha
2023-08-08 6:08 ` [PATCH 33/33] " Karim Taha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e757317-35c3-634a-a6dd-1ac267a2bf67@linaro.org \
--to=richard.henderson@linaro.org \
--cc=imp@bsdimp.com \
--cc=kariem.taha2.7@gmail.com \
--cc=mmel@FreeBSD.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).