From: Jason Wang <jasowang@redhat.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>,
qemu-devel@nongnu.org, dgilbert@redhat.com
Cc: quintela@redhat.com, zhangchen.fnst@cn.fujitsu.com,
Li Zhijian <lizhijian@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH RESEND v2 01/18] net/colo: Add notifier/callback related helpers for filter
Date: Tue, 25 Apr 2017 19:40:34 +0800 [thread overview]
Message-ID: <5e7f11a4-83d4-e363-6f80-a749c206c190@redhat.com> (raw)
In-Reply-To: <1492850128-17472-2-git-send-email-zhang.zhanghailiang@huawei.com>
On 2017年04月22日 16:35, zhanghailiang wrote:
> We will use this notifier to help COLO to notify filter object
> to do something, like do checkpoint, or process failover event.
>
> Cc: Jason Wang<jasowang@redhat.com>
> Signed-off-by: zhanghailiang<zhang.zhanghailiang@huawei.com>
> Signed-off-by: Zhang Chen<zhangchen.fnst@cn.fujitsu.com>
> Signed-off-by: Li Zhijian<lizhijian@cn.fujitsu.com>
> ---
> net/colo.c | 105 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> net/colo.h | 19 +++++++++++
> 2 files changed, 124 insertions(+)
Went through this series and I feel that the code duplicates (at least
part) functionality of IOThread (iothread.c) . So I come to an idea that
switch to use IOThread for COLO comparing thread then you can use aio bh
to do the inter process communication.
Thoughts?
Thanks
next prev parent reply other threads:[~2017-04-25 11:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-22 8:35 [Qemu-devel] [PATCH RESEND v2 00/18] COLO: integrate colo frame with block replication and net compare zhanghailiang
2017-04-22 8:35 ` [Qemu-devel] [PATCH RESEND v2 01/18] net/colo: Add notifier/callback related helpers for filter zhanghailiang
2017-04-25 11:40 ` Jason Wang [this message]
2017-04-26 8:14 ` Hailiang Zhang
2017-04-26 9:14 ` Jason Wang
2017-04-22 8:35 ` [Qemu-devel] [PATCH RESEND v2 02/18] colo-compare: implement the process of checkpoint zhanghailiang
2017-04-22 8:35 ` [Qemu-devel] [PATCH RESEND v2 03/18] colo-compare: use notifier to notify packets comparing result zhanghailiang
2017-04-22 8:35 ` [Qemu-devel] [PATCH RESEND v2 04/18] COLO: integrate colo compare with colo frame zhanghailiang
2017-04-24 18:18 ` Juan Quintela
2017-04-25 11:03 ` Hailiang Zhang
2017-04-22 8:35 ` [Qemu-devel] [PATCH RESEND v2 05/18] COLO: Handle shutdown command for VM in COLO state zhanghailiang
2017-04-22 8:35 ` [Qemu-devel] [PATCH RESEND v2 06/18] COLO: Add block replication into colo process zhanghailiang
2017-04-22 8:35 ` [Qemu-devel] [PATCH RESEND v2 07/18] COLO: Load dirty pages into SVM's RAM cache firstly zhanghailiang
2017-04-24 18:27 ` Juan Quintela
2017-04-25 11:06 ` Hailiang Zhang
2017-04-22 8:35 ` [Qemu-devel] [PATCH RESEND v2 08/18] ram/COLO: Record the dirty pages that SVM received zhanghailiang
2017-04-24 18:29 ` Juan Quintela
2017-04-25 11:19 ` Hailiang Zhang
2017-04-22 8:35 ` [Qemu-devel] [PATCH RESEND v2 09/18] COLO: Flush memory data from ram cache zhanghailiang
2017-04-22 8:35 ` [Qemu-devel] [PATCH RESEND v2 10/18] qmp event: Add COLO_EXIT event to notify users while exited COLO zhanghailiang
2017-04-22 8:35 ` [Qemu-devel] [PATCH RESEND v2 11/18] savevm: split save/find loadvm_handlers entry into two helper functions zhanghailiang
2017-04-22 8:35 ` [Qemu-devel] [PATCH RESEND v2 12/18] savevm: split the process of different stages for loadvm/savevm zhanghailiang
2017-04-22 8:35 ` [Qemu-devel] [PATCH RESEND v2 13/18] COLO: Separate the process of saving/loading ram and device state zhanghailiang
2017-04-22 8:35 ` [Qemu-devel] [PATCH RESEND v2 14/18] COLO: Split qemu_savevm_state_begin out of checkpoint process zhanghailiang
2017-04-22 8:35 ` [Qemu-devel] [PATCH RESEND v2 15/18] COLO: flush host dirty ram from cache zhanghailiang
2017-04-22 8:35 ` [Qemu-devel] [PATCH RESEND v2 16/18] filter: Add handle_event method for NetFilterClass zhanghailiang
2017-04-22 8:35 ` [Qemu-devel] [PATCH RESEND v2 17/18] filter-rewriter: handle checkpoint and failover event zhanghailiang
2017-04-22 8:35 ` [Qemu-devel] [PATCH RESEND v2 18/18] COLO: notify net filters about checkpoint/failover event zhanghailiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e7f11a4-83d4-e363-6f80-a749c206c190@redhat.com \
--to=jasowang@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhangchen.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).