From: Ryota Ozaki <ozaki.ryota@gmail.com>
To: libvir-list@redhat.com
Cc: Ryota OZAKI <ozaki.ryota@gmail.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] address incompatible change of qemu-img
Date: Tue, 4 Aug 2009 11:43:23 +0900 [thread overview]
Message-ID: <5e93dcec0908031943n43ef28b8n77e70c6a470cd950@mail.gmail.com> (raw)
Hi,
Latest qemu-img (maybe from 0.11.0-rc0 or later?) changes
default unit of size as bytes, it was kilo-bytes so far.
(see http://www.mail-archive.com/kvm@vger.kernel.org/msg19183.html)
This patch addresses this incompatibility by adding postfix
'K'. This fix is able to keep backward compatibility for
old qemu as well, and also even if qemu-img falls back old
style or any, this explicit specifying should work well.
Thanks,
ozaki-r
>From 7d3dd9e592deab5a1d793532cf230d8367372280 Mon Sep 17 00:00:00 2001
From: Ryota Ozaki <ozaki.ryota@gmail.com>
Date: Tue, 4 Aug 2009 11:11:31 +0900
Subject: [PATCH] address incompatible change of qemu-img
---
src/storage_backend.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/storage_backend.c b/src/storage_backend.c
index 07a2e48..8824218 100644
--- a/src/storage_backend.c
+++ b/src/storage_backend.c
@@ -446,7 +446,7 @@ virStorageBackendCreateQemuImg(virConnectPtr conn,
/* Size in KB */
- snprintf(size, sizeof(size), "%llu", vol->capacity/1024);
+ snprintf(size, sizeof(size), "%lluK", vol->capacity/1024);
if (virRun(conn, imgargv, NULL) < 0) {
VIR_FREE(imgargv[0]);
--
1.6.0.6
reply other threads:[~2009-08-04 2:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e93dcec0908031943n43ef28b8n77e70c6a470cd950@mail.gmail.com \
--to=ozaki.ryota@gmail.com \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).