From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NsslP-0007SA-Ct
	for qemu-devel@nongnu.org; Sat, 20 Mar 2010 03:06:27 -0400
Received: from [199.232.76.173] (port=37904 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NsslO-0007RS-Ni
	for qemu-devel@nongnu.org; Sat, 20 Mar 2010 03:06:26 -0400
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <ozaki.ryota@gmail.com>) id 1NsslN-0002el-Ks
	for qemu-devel@nongnu.org; Sat, 20 Mar 2010 03:06:26 -0400
Received: from mail-pw0-f45.google.com ([209.85.160.45]:44105)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <ozaki.ryota@gmail.com>) id 1NsslN-0002eL-CI
	for qemu-devel@nongnu.org; Sat, 20 Mar 2010 03:06:25 -0400
Received: by pwi9 with SMTP id 9so2630943pwi.4
	for <qemu-devel@nongnu.org>; Sat, 20 Mar 2010 00:06:19 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <m3634rlbmq.fsf@blackfin.pond.sub.org>
References: <1269066204-4376-1-git-send-email-ozaki.ryota@gmail.com>
	<m3634rlbmq.fsf@blackfin.pond.sub.org>
From: Ryota Ozaki <ozaki.ryota@gmail.com>
Date: Sat, 20 Mar 2010 16:05:59 +0900
Message-ID: <5e93dcec1003200005u414ccc5dp683fca26acfc7f8b@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] qemu-nbd: Fix return value handling of
	bdrv_open
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On Sat, Mar 20, 2010 at 4:01 PM, Markus Armbruster <armbru@redhat.com> wrot=
e:
> Ryota Ozaki <ozaki.ryota@gmail.com> writes:
>
>> bdrv_open may return -errno so we have to check
>> if the return value is '< 0', not '=3D=3D -1'.
>>
>> Signed-off-by: Ryota Ozaki <ozaki.ryota@gmail.com>
>> ---
>> =A0qemu-nbd.c | =A0 =A02 +-
>> =A01 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/qemu-nbd.c b/qemu-nbd.c
>> index a393583..b89c361 100644
>> --- a/qemu-nbd.c
>> +++ b/qemu-nbd.c
>> @@ -333,7 +333,7 @@ int main(int argc, char **argv)
>> =A0 =A0 =A0if (bs =3D=3D NULL)
>> =A0 =A0 =A0 =A0 =A0return 1;
>>
>> - =A0 =A0if (bdrv_open(bs, argv[optind], flags) =3D=3D -1)
>> + =A0 =A0if (bdrv_open(bs, argv[optind], flags) < 0)
>> =A0 =A0 =A0 =A0 =A0return 1;
>>
>> =A0 =A0 =A0fd_size =3D bs->total_sectors * 512;
>
> Same bug in qemu-io.c. =A0Could you fix that as well?
>

OK. I will.

Thanks,
  ozaki-r