From: David Hildenbrand <david@redhat.com>
To: Raphael Norwitz <raphael.norwitz@nutanix.com>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"marcandre.lureau@redhat.com" <marcandre.lureau@redhat.com>,
"mst@redhat.com" <mst@redhat.com>
Cc: "raphael.s.norwitz@gmail.com" <raphael.s.norwitz@gmail.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v3 6/6] libvhost-user: handle removal of identical regions
Date: Mon, 17 Jan 2022 09:21:36 +0100 [thread overview]
Message-ID: <5eac0540-fc45-0d17-7b69-143d37004d96@redhat.com> (raw)
In-Reply-To: <20220117041050.19718-7-raphael.norwitz@nutanix.com>
On 17.01.22 05:12, Raphael Norwitz wrote:
> Today if QEMU (or any other VMM) has sent multiple copies of the same
> region to a libvhost-user based backend and then attempts to remove the
> region, only one instance of the region will be removed, leaving stale
> copies of the region in dev->regions[].
>
> This change resolves this by having vu_rem_mem_reg() iterate through all
> regions in dev->regions[] and delete all matching regions.
>
> Suggested-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2022-01-17 8:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 4:12 [PATCH v3 0/6] Clean up error handling in libvhost-user memory mapping Raphael Norwitz
2022-01-17 4:12 ` [PATCH v3 1/6] libvhost-user: Add vu_rem_mem_reg input validation Raphael Norwitz
2022-01-17 8:19 ` David Hildenbrand
2022-01-17 4:12 ` [PATCH v3 2/6] libvhost-user: Add vu_add_mem_reg " Raphael Norwitz
2022-01-17 8:19 ` David Hildenbrand
2022-01-17 4:12 ` [PATCH v3 3/6] libvhost-user: Simplify VHOST_USER_REM_MEM_REG Raphael Norwitz
2022-01-17 4:12 ` [PATCH v3 4/6] libvhost-user: fix VHOST_USER_REM_MEM_REG not closing the fd Raphael Norwitz
2022-01-17 4:12 ` [PATCH v3 5/6] libvhost-user: prevent over-running max RAM slots Raphael Norwitz
2022-01-17 8:20 ` David Hildenbrand
2022-01-17 12:32 ` Philippe Mathieu-Daudé via
2022-01-17 4:12 ` [PATCH v3 6/6] libvhost-user: handle removal of identical regions Raphael Norwitz
2022-01-17 8:21 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5eac0540-fc45-0d17-7b69-143d37004d96@redhat.com \
--to=david@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=raphael.s.norwitz@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).