From: Eric Blake <eblake@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Laine Stump <laine@redhat.com>,
libvir-list@redhat.com, sferdjao@redhat.com, berrange@redhat.com,
Sahid Orentino Ferdjaoui <sahid.ferdjaoui@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] qemu: add capability for vhost-net busy polling
Date: Mon, 26 Jun 2017 21:41:41 -0500 [thread overview]
Message-ID: <5ecaf1a4-1308-0669-3468-f9883172da61@redhat.com> (raw)
In-Reply-To: <20170627022421.GT12152@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 2178 bytes --]
On 06/26/2017 09:24 PM, Eduardo Habkost wrote:
>> I've posted patches in the past (qemu 2.6 timeframe, if I recall) that
>> changed netdev_add into a fully-advertised interface, but we didn't take
>> it then because we weren't sure how to handle the fact that netdev_add
>> can currently accept both an integer (1) and a string ("1") as
>> identical, and we didn't want to risk breaking clients that passed a
>> string when the promoted command would only accept integers. I guess we
>> should revive that.
>>
>>>
>>> Markus, Eric, Michael: is there any way libvirt can query the
>>> definition of union Netdev from the schema with current QEMU?
>>
>> Really, we need to promote netdev_add to a full-fledged QMP command.
Remember, netdev_add and object_add are the only two outlier QMP
commands that have NOT been converted to use QAPI. We've already done
most of the work at making QMP netdev_add and command line -netdev be
compatible, it is just the last bit of switching on full QAPI support
that has some interface ramifications that we were not comfortable
making during a release freeze, and haven't had time to revisit since.
object_add is much further away from being introspectible.
>
> This may be enough for -netdev, but do we want to make command-line
> option introspection always depend on having the same struct being used
> in a QMP command to work? What if the arguments for the command-line
> option don't match precisely the input of a QMP command?
Then that's arguably a poor user interface, and only something we should
do for back-compat reasons, and not for new design. We WANT to make the
command-line introspectible, and the easiest way to do that is to make
the command-line and QMP share common guts (see the recent -blockdev
addition in qemu 2.9, along with Dan and Markus' work at tweaking
visitors so that the command line directly feeds into the QObject
representation used by QMP commands rather than the hackish QemuOpts
that is already too bloated with workarounds).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2017-06-27 2:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170615141715.17708-1-sferdjao@redhat.com>
[not found] ` <20170615141715.17708-2-sferdjao@redhat.com>
[not found] ` <2bb5a8a3-37c9-3dd2-4483-c8a2fed5bb4d@redhat.com>
2017-06-18 3:15 ` [Qemu-devel] [PATCH 1/3] qemu: add capability for vhost-net busy polling Eduardo Habkost
2017-06-26 13:23 ` Eric Blake
2017-06-27 2:24 ` Eduardo Habkost
2017-06-27 2:41 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ecaf1a4-1308-0669-3468-f9883172da61@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=laine@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=sahid.ferdjaoui@redhat.com \
--cc=sferdjao@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).