Re: [RFC V3 PATCH 13/13] acpi: hmp/qmp: Add hmp/qmp support for system_sleep

[Annie Li <annie.li@oracle.com>]

Hi Gustavo,

On 4/17/2025 1:37 PM, Gustavo Romero wrote:
> Hi Annie,
>
> On 4/14/25 11:14, Annie Li wrote:
>>
>> On 4/14/2025 2:31 AM, Markus Armbruster wrote:
>>> Annie Li <annie.li@oracle.com> writes:
>>>
>>>> Followng hmp/qmp commands are implemented for pressing virtual
>>>> sleep button,
>
> nit: Following

Oops! will fix it.
Thanks for the catch.

Annie

>
>
> Cheers,
> Gustavo
>
>>>> hmp: system_sleep
>>>> qmp: { "execute": "system_sleep" }
>>>>
>>>> These commands put the guest into suspend or other power states
>>>> depending on the power settings inside the guest.
>>>>
>>>> These hmp/qmp command are in '*_*' format, it is intended to do
>>>> so to align to existing 'system_*' commands.
>>>>
>>>> Signed-off-by: Annie Li <annie.li@oracle.com>
>>> [...]
>>>
>>>> diff --git a/qapi/machine.json b/qapi/machine.json
>>>> index a6b8795b09..0965e78f4e 100644
>>>> --- a/qapi/machine.json
>>>> +++ b/qapi/machine.json
>>>> @@ -361,6 +361,26 @@
>>>>   ##
>>>>   { 'command': 'system_reset' }
>>>> +##
>>>> +# @system_sleep:
>>>> +#
>>>> +# Requests that the guest perform a ACPI sleep transition by pushing
>>>> +# the virtual sleep button.
>>>> +#
>>>> +# Since:10.0
>>>> +#
>>>> +# .. note:: A guest may or may not respond to this command. This
>>> Two spaces between sentences for consistency, please.
>>
>> Didn't notice this, thanks for pointing it out.
>>
>> Will fix it.
>>
>> Thanks
>>
>> Annie
>>
>>>
>>>> +#        command returning does not indicate that a guest has
>>>> +#        accepted the request or that it has gone to sleep.
>>>> +#
>>>> +# .. qmp-example::
>>>> +#
>>>> +# -> { "execute": "system_sleep" }
>>>> +# <- { "return": {} }
>>>> +#
>>>> +##
>>>> +{ 'command': 'system_sleep' }
>>>> +
>>>>   ##
>>>>   # @system_powerdown:
>>>>   #
>>>> diff --git a/qapi/pragma.json b/qapi/pragma.json
>>>> index 023a2ef7bc..285ce82e9b 100644
>>>> --- a/qapi/pragma.json
>>>> +++ b/qapi/pragma.json
>>>> @@ -23,6 +23,7 @@
>>>>           'set_password',
>>>>           'system_powerdown',
>>>>           'system_reset',
>>>> +        'system_sleep',
>>> Additions here are always sad, but inconsistency with the other
>>> system_FOO commands would be worse.
>>>
>>>>           'system_wakeup' ],
>>>>       # Commands allowed to return a non-dictionary
>>>>       'command-returns-exceptions': [
>>> With the spacing nit touched up:
>>> Acked-by: Markus Armbruster <armbru@redhat.com>
>>>
>>
>