From: Richard Henderson <richard.henderson@linaro.org>
To: "Cédric Le Goater" <clg@kaod.org>, qemu-devel@nongnu.org
Cc: "Cédric Le Goater" <clg@redhat.com>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>
Subject: Re: [PATCH for-8.0 3/3] target/ppc: Fix helper_pminsn() prototype
Date: Tue, 21 Mar 2023 20:49:38 -0700 [thread overview]
Message-ID: <5ee84a26-ddc7-2ecb-66f1-20adc34bd214@linaro.org> (raw)
In-Reply-To: <20230321083322.663561-4-clg@kaod.org>
On 3/21/23 01:33, Cédric Le Goater wrote:
> From: Cédric Le Goater<clg@redhat.com>
>
> GCC13 reports an error:
>
> ../target/ppc/excp_helper.c:2625:6: error: conflicting types for ‘helper_pminsn’ due to enum/integer mismatch; have ‘void(CPUPPCState *, powerpc_pm_insn_t)’ {aka ‘void(struct CPUArchState *, powerpc_pm_insn_t)’} [-Werror=enum-int-mismatch]
> 2625 | void helper_pminsn(CPUPPCState *env, powerpc_pm_insn_t insn)
> | ^~~~~~~~~~~~~
> In file included from /home/legoater/work/qemu/qemu.git/include/qemu/osdep.h:49,
> from ../target/ppc/excp_helper.c:19:
> /home/legoater/work/qemu/qemu.git/include/exec/helper-head.h:23:27: note: previous declaration of ‘helper_pminsn’ with type ‘void(CPUArchState *, uint32_t)’ {aka ‘void(CPUArchState *, unsigned int)’}
> 23 | #define HELPER(name) glue(helper_, name)
> | ^~~~~~~
>
> Cc: Daniel Henrique Barboza<danielhb413@gmail.com>
> Fixes: 7778a575c7 ("ppc: Add P7/P8 Power Management instructions")
> Signed-off-by: Cédric Le Goater<clg@redhat.com>
> ---
> target/ppc/excp_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2023-03-22 3:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 8:33 [PATCH for-8.0 0/3] Fixes for GCC13 Cédric Le Goater
2023-03-21 8:33 ` [PATCH for-8.0 1/3] async: Suppress GCC13 false positive in aio_bh_poll() Cédric Le Goater
2023-03-21 10:22 ` Paolo Bonzini
2023-03-21 10:30 ` Daniel P. Berrangé
2023-03-21 10:57 ` Paolo Bonzini
2023-03-21 11:15 ` Stefan Hajnoczi
2023-03-21 11:57 ` Paolo Bonzini
2023-03-21 12:16 ` Cédric Le Goater
2023-03-21 13:02 ` Paolo Bonzini
2023-03-21 8:33 ` [PATCH for-8.0 2/3] target/s390x: Fix float_comp_to_cc() prototype Cédric Le Goater
2023-03-21 9:37 ` Philippe Mathieu-Daudé
2023-03-22 3:48 ` Richard Henderson
2023-03-22 6:51 ` Thomas Huth
2023-03-21 8:33 ` [PATCH for-8.0 3/3] target/ppc: Fix helper_pminsn() prototype Cédric Le Goater
2023-03-21 11:07 ` Daniel Henrique Barboza
2023-03-22 3:49 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ee84a26-ddc7-2ecb-66f1-20adc34bd214@linaro.org \
--to=richard.henderson@linaro.org \
--cc=clg@kaod.org \
--cc=clg@redhat.com \
--cc=danielhb413@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).