* [Qemu-devel] [RISU PATCH] risu: Include <sys/user.h> on ppc64
@ 2019-06-07 13:25 Peter Maydell
2019-06-07 14:00 ` Alex Bennée
2019-06-10 4:25 ` Sandipan Das
0 siblings, 2 replies; 4+ messages in thread
From: Peter Maydell @ 2019-06-07 13:25 UTC (permalink / raw)
To: qemu-devel; +Cc: Sandipan Das, Alex Bennée
To build the C parts of risu for ppc64le with recent glibc/kernel
headers, we need to include sys/user.h to avoid a compile error,
because sys/ucontext.h defines a struct which includes a pointer
to 'struct pt_regs' but does not provide a definition of that struct.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
I need this to be able to do the ppc64le cross-build on my
Ubuntu Bionic x86-64 system.
risu_ppc64.c | 2 ++
risu_reginfo_ppc64.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/risu_ppc64.c b/risu_ppc64.c
index 83f8d1f..a3028f7 100644
--- a/risu_ppc64.c
+++ b/risu_ppc64.c
@@ -11,6 +11,8 @@
* based on Peter Maydell's risu_arm.c
*****************************************************************************/
+#include <sys/user.h>
+
#include "risu.h"
void advance_pc(void *vuc)
diff --git a/risu_reginfo_ppc64.c b/risu_reginfo_ppc64.c
index f9d2f0d..071c951 100644
--- a/risu_reginfo_ppc64.c
+++ b/risu_reginfo_ppc64.c
@@ -16,6 +16,7 @@
#include <string.h>
#include <math.h>
#include <stdlib.h>
+#include <sys/user.h>
#include "risu.h"
#include "risu_reginfo_ppc64.h"
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [RISU PATCH] risu: Include <sys/user.h> on ppc64
2019-06-07 13:25 [Qemu-devel] [RISU PATCH] risu: Include <sys/user.h> on ppc64 Peter Maydell
@ 2019-06-07 14:00 ` Alex Bennée
2019-06-10 4:25 ` Sandipan Das
1 sibling, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2019-06-07 14:00 UTC (permalink / raw)
To: Peter Maydell; +Cc: Sandipan Das, qemu-devel
Peter Maydell <peter.maydell@linaro.org> writes:
> To build the C parts of risu for ppc64le with recent glibc/kernel
> headers, we need to include sys/user.h to avoid a compile error,
> because sys/ucontext.h defines a struct which includes a pointer
> to 'struct pt_regs' but does not provide a definition of that struct.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> I need this to be able to do the ppc64le cross-build on my
> Ubuntu Bionic x86-64 system.
>
> risu_ppc64.c | 2 ++
> risu_reginfo_ppc64.c | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/risu_ppc64.c b/risu_ppc64.c
> index 83f8d1f..a3028f7 100644
> --- a/risu_ppc64.c
> +++ b/risu_ppc64.c
> @@ -11,6 +11,8 @@
> * based on Peter Maydell's risu_arm.c
> *****************************************************************************/
>
> +#include <sys/user.h>
> +
> #include "risu.h"
>
> void advance_pc(void *vuc)
> diff --git a/risu_reginfo_ppc64.c b/risu_reginfo_ppc64.c
> index f9d2f0d..071c951 100644
> --- a/risu_reginfo_ppc64.c
> +++ b/risu_reginfo_ppc64.c
> @@ -16,6 +16,7 @@
> #include <string.h>
> #include <math.h>
> #include <stdlib.h>
> +#include <sys/user.h>
>
> #include "risu.h"
> #include "risu_reginfo_ppc64.h"
--
Alex Bennée
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [RISU PATCH] risu: Include <sys/user.h> on ppc64
2019-06-07 13:25 [Qemu-devel] [RISU PATCH] risu: Include <sys/user.h> on ppc64 Peter Maydell
2019-06-07 14:00 ` Alex Bennée
@ 2019-06-10 4:25 ` Sandipan Das
2019-06-13 12:33 ` Peter Maydell
1 sibling, 1 reply; 4+ messages in thread
From: Sandipan Das @ 2019-06-10 4:25 UTC (permalink / raw)
To: Peter Maydell; +Cc: Alex Bennée, qemu-devel
On 07/06/19 6:55 PM, Peter Maydell wrote:
> To build the C parts of risu for ppc64le with recent glibc/kernel
> headers, we need to include sys/user.h to avoid a compile error,
> because sys/ucontext.h defines a struct which includes a pointer
> to 'struct pt_regs' but does not provide a definition of that struct.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
LGTM.
Reviewed-by: Sandipan Das <sandipan@linux.ibm.com>
> ---
> I need this to be able to do the ppc64le cross-build on my
> Ubuntu Bionic x86-64 system.
>
> risu_ppc64.c | 2 ++
> risu_reginfo_ppc64.c | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/risu_ppc64.c b/risu_ppc64.c
> index 83f8d1f..a3028f7 100644
> --- a/risu_ppc64.c
> +++ b/risu_ppc64.c
> @@ -11,6 +11,8 @@
> * based on Peter Maydell's risu_arm.c
> *****************************************************************************/
>
> +#include <sys/user.h>
> +
> #include "risu.h"
>
> void advance_pc(void *vuc)
> diff --git a/risu_reginfo_ppc64.c b/risu_reginfo_ppc64.c
> index f9d2f0d..071c951 100644
> --- a/risu_reginfo_ppc64.c
> +++ b/risu_reginfo_ppc64.c
> @@ -16,6 +16,7 @@
> #include <string.h>
> #include <math.h>
> #include <stdlib.h>
> +#include <sys/user.h>
>
> #include "risu.h"
> #include "risu_reginfo_ppc64.h"
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [RISU PATCH] risu: Include <sys/user.h> on ppc64
2019-06-10 4:25 ` Sandipan Das
@ 2019-06-13 12:33 ` Peter Maydell
0 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2019-06-13 12:33 UTC (permalink / raw)
To: Sandipan Das; +Cc: Alex Bennée, QEMU Developers
On Mon, 10 Jun 2019 at 05:25, Sandipan Das <sandipan@linux.ibm.com> wrote:
>
>
>
> On 07/06/19 6:55 PM, Peter Maydell wrote:
> > To build the C parts of risu for ppc64le with recent glibc/kernel
> > headers, we need to include sys/user.h to avoid a compile error,
> > because sys/ucontext.h defines a struct which includes a pointer
> > to 'struct pt_regs' but does not provide a definition of that struct.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> LGTM.
>
> Reviewed-by: Sandipan Das <sandipan@linux.ibm.com>
Thanks; pushed to risu master.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-13 13:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-07 13:25 [Qemu-devel] [RISU PATCH] risu: Include <sys/user.h> on ppc64 Peter Maydell
2019-06-07 14:00 ` Alex Bennée
2019-06-10 4:25 ` Sandipan Das
2019-06-13 12:33 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).