From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Bruno <sbruno@freebsd.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] Use "-s" instead of "--quiet" to resolve non-fatal build error on FreeBSD.
Date: Tue, 5 Jul 2016 18:59:02 +0200 [thread overview]
Message-ID: <5f1246cd-8cc7-d15d-d855-a480a9eac27e@redhat.com> (raw)
In-Reply-To: <20160614180734.8782-1-sbruno@freebsd.org>
On 14/06/2016 20:07, Sean Bruno wrote:
> The --quiet argument is not available on all operating systems. Use -s
> instead to match the rest of the Makefile uses. This fixes a non-fatal
> error seen on FreeBSD.
>
> Signed-off-by: Sean Bruno <sbruno@freebsd.org>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index ed4032a..a7a356a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -185,7 +185,7 @@ qemu-version.h: FORCE
> printf '""\n'; \
> fi; \
> fi) > $@.tmp)
> - $(call quiet-command, cmp --quiet $@ $@.tmp || mv $@.tmp $@)
> + $(call quiet-command, cmp -s $@ $@.tmp || mv $@.tmp $@)
>
> config-host.h: config-host.h-timestamp
> config-host.h-timestamp: config-host.mak
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2016-07-05 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 18:07 [Qemu-devel] [PATCH v2] Use "-s" instead of "--quiet" to resolve non-fatal build error on FreeBSD Sean Bruno
2016-06-14 22:11 ` Eric Blake
2016-06-15 0:32 ` Fam Zheng
2016-07-05 16:59 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f1246cd-8cc7-d15d-d855-a480a9eac27e@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sbruno@freebsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).