qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>, qemu-devel@nongnu.org
Cc: drjones@redhat.com, thuth@redhat.com, alex.bennee@linaro.org,
	ehabkost@redhat.com, crosa@redhat.com
Subject: Re: [PATCH v4 4/8] python/qemu: accel: Fix kvm_available() on ppc64le
Date: Thu, 6 Feb 2020 16:43:21 +0100	[thread overview]
Message-ID: <5f3ba490-ea0b-f2fe-d314-e7c08db7ca95@redhat.com> (raw)
In-Reply-To: <20200205203250.30526-5-wainersm@redhat.com>

On 2/5/20 9:32 PM, Wainer dos Santos Moschetta wrote:
> On ppc64le, the accel.kvm_available() check may wrongly
> return False because the host arch (as returned by os.uname[4])
> and the target arch (ppc64) mismatch. In order to solve this
> it is added an ppc64le -> ppc64 mapping which is used as an
> fallback verification.
> 
> Fixes: 53a049d7d78e5ccf6d4c0d7
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> ---
>   python/qemu/accel.py | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/python/qemu/accel.py b/python/qemu/accel.py
> index 0b38ddf0ab..36ae85791e 100644
> --- a/python/qemu/accel.py
> +++ b/python/qemu/accel.py
> @@ -24,7 +24,8 @@ LOG = logging.getLogger(__name__)
>   # support which often includes its 32 bit cousin.
>   ADDITIONAL_ARCHES = {
>       "x86_64" : "i386",
> -    "aarch64" : "armhf"
> +    "aarch64" : "armhf",
> +    "ppc64le" : "ppc64",
>   }
>   
>   def list_accel(qemu_bin):
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

And applied to my python-next tree:
https://gitlab.com/philmd/qemu/commits/python-next



  reply	other threads:[~2020-02-06 15:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05 20:32 [PATCH v4 0/8] Acceptance tests: boot Linux with KVM test Wainer dos Santos Moschetta
2020-02-05 20:32 ` [PATCH v4 1/8] tests/acceptance: avocado_qemu: Introduce the 'accel' test parameter Wainer dos Santos Moschetta
2020-02-05 20:32 ` [PATCH v4 2/8] tests/acceptance: boot_linux_console: Add boot Linux/x86 with KVM Wainer dos Santos Moschetta
2020-02-05 20:32 ` [PATCH v4 3/8] tests/acceptance: boot_linux_console: Add boot Linux/aarch64 " Wainer dos Santos Moschetta
2020-02-05 20:32 ` [PATCH v4 4/8] python/qemu: accel: Fix kvm_available() on ppc64le Wainer dos Santos Moschetta
2020-02-06 15:43   ` Philippe Mathieu-Daudé [this message]
2020-02-05 20:32 ` [PATCH v4 5/8] test/acceptance: boot_linux_console: Add boot Linux/ppc64le with KVM Wainer dos Santos Moschetta
2020-02-05 20:32 ` [PATCH v4 6/8] tests/acceptance: boot_linux_console: Add boot Linux/s390x " Wainer dos Santos Moschetta
2020-02-05 20:32 ` [PATCH v4 7/8] tests/acceptance: avocado_qemu: Refactor the handler of 'machine' parameter Wainer dos Santos Moschetta
2020-02-06 15:41   ` Philippe Mathieu-Daudé
2020-02-05 20:32 ` [PATCH v4 8/8] travis.yml: Enable acceptance KVM tests Wainer dos Santos Moschetta
2020-02-10 14:53 ` [PATCH v4 0/8] Acceptance tests: boot Linux with KVM test Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f3ba490-ea0b-f2fe-d314-e7c08db7ca95@redhat.com \
    --to=philmd@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=crosa@redhat.com \
    --cc=drjones@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).