From: David Hildenbrand <david@redhat.com>
To: Michal Privoznik <mprivozn@redhat.com>, qemu-devel@nongnu.org
Cc: imammedo@redhat.com
Subject: Re: [PATCH v2 3/4] backends/hostmem: Report error on qemu_madvise() failures
Date: Fri, 31 May 2024 11:10:22 +0200 [thread overview]
Message-ID: <5f47930e-4d33-42e1-ab51-f53a07aee1f6@redhat.com> (raw)
In-Reply-To: <3341689328d280183062a8fcde006468346ecf1d.1717140354.git.mprivozn@redhat.com>
On 31.05.24 09:28, Michal Privoznik wrote:
> If user sets .merge or .dump attributes qemu_madvise() is called
> with corresponding advice. But it is never checked for failure
> which may mislead users into thinking the attribute is set
> correctly. Report an appropriate error.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-05-31 9:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 7:28 [PATCH v2 0/4] backends/hostmem: Report more errors on failures Michal Privoznik
2024-05-31 7:28 ` [PATCH v2 1/4] osdep: Make qemu_madvise() to set errno in all cases Michal Privoznik
2024-05-31 7:57 ` Philippe Mathieu-Daudé
2024-05-31 8:01 ` David Hildenbrand
2024-05-31 8:12 ` Philippe Mathieu-Daudé
2024-05-31 9:08 ` David Hildenbrand
2024-05-31 11:10 ` Michal Prívozník
2024-05-31 7:28 ` [PATCH v2 2/4] osdep: Make qemu_madvise() return ENOSYS on unsupported OSes Michal Privoznik
2024-05-31 7:48 ` Philippe Mathieu-Daudé
2024-05-31 7:53 ` David Hildenbrand
2024-05-31 8:02 ` Philippe Mathieu-Daudé
2024-05-31 7:28 ` [PATCH v2 3/4] backends/hostmem: Report error on qemu_madvise() failures Michal Privoznik
2024-05-31 7:49 ` Philippe Mathieu-Daudé
2024-05-31 9:10 ` David Hildenbrand [this message]
2024-05-31 7:29 ` [PATCH v2 4/4] backends/hostmem: Report error when memory size is unaligned Michal Privoznik
2024-05-31 7:53 ` Philippe Mathieu-Daudé
2024-06-05 7:12 ` Mario Casquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f47930e-4d33-42e1-ab51-f53a07aee1f6@redhat.com \
--to=david@redhat.com \
--cc=imammedo@redhat.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).