Re: [EXTERNAL] [PATCH] hw/mips/jazz: fix typo in in-built NIC alias

[David Woodhouse <dwmw2@infradead.org>]

[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]

On Sat, 2024-09-07 at 06:08 +0200, Philippe Mathieu-Daudé wrote:
> On 7/9/24 01:01, Mark Cave-Ayland wrote:
> > Commit e104edbb9d ("hw/mips/jazz: use qemu_find_nic_info()") contained a typo
> > in the NIC alias which caused initialisation of the in-built dp83932 NIC to fail
> > when using the normal -nic user,model=dp83932 command line.
> > 
> 
> Cc: qemu-stable@nongnu.org # v9.0
> Fixes: e104edbb9d ("hw/mips/jazz: use qemu_find_nic_info()")
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>

Thanks.

> > Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> > ---
> >   hw/mips/jazz.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/hw/mips/jazz.c b/hw/mips/jazz.c
> > index 1bc17e69d3..0d44e19707 100644
> > --- a/hw/mips/jazz.c
> > +++ b/hw/mips/jazz.c
> > @@ -128,7 +128,7 @@ static void mips_jazz_init_net(IOMMUMemoryRegion *rc4030_dma_mr,
> >       uint8_t *prom;
> >       NICInfo *nd;
> > 
> > -    nd = qemu_find_nic_info("dp8393x", true, "dp82932");
> > +    nd = qemu_find_nic_info("dp8393x", true, "dp83932");
> >       if (!nd) {
> >           return;
> >       }
> 


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]