* [PATCH] hw/mips/jazz: fix typo in in-built NIC alias
@ 2024-09-06 23:01 Mark Cave-Ayland
2024-09-07 4:08 ` Philippe Mathieu-Daudé
2024-09-07 12:11 ` Michael Tokarev
0 siblings, 2 replies; 4+ messages in thread
From: Mark Cave-Ayland @ 2024-09-06 23:01 UTC (permalink / raw)
To: hpoussin, arikalo, philmd, jiaxun.yang, dwmw, qemu-devel,
qemu-stable
Commit e104edbb9d ("hw/mips/jazz: use qemu_find_nic_info()") contained a typo
in the NIC alias which caused initialisation of the in-built dp83932 NIC to fail
when using the normal -nic user,model=dp83932 command line.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
hw/mips/jazz.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/mips/jazz.c b/hw/mips/jazz.c
index 1bc17e69d3..0d44e19707 100644
--- a/hw/mips/jazz.c
+++ b/hw/mips/jazz.c
@@ -128,7 +128,7 @@ static void mips_jazz_init_net(IOMMUMemoryRegion *rc4030_dma_mr,
uint8_t *prom;
NICInfo *nd;
- nd = qemu_find_nic_info("dp8393x", true, "dp82932");
+ nd = qemu_find_nic_info("dp8393x", true, "dp83932");
if (!nd) {
return;
}
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] hw/mips/jazz: fix typo in in-built NIC alias
2024-09-06 23:01 [PATCH] hw/mips/jazz: fix typo in in-built NIC alias Mark Cave-Ayland
@ 2024-09-07 4:08 ` Philippe Mathieu-Daudé
2024-09-07 9:25 ` [EXTERNAL] " David Woodhouse
2024-09-07 12:11 ` Michael Tokarev
1 sibling, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-09-07 4:08 UTC (permalink / raw)
To: Mark Cave-Ayland, hpoussin, arikalo, jiaxun.yang, dwmw,
qemu-devel, qemu-stable
On 7/9/24 01:01, Mark Cave-Ayland wrote:
> Commit e104edbb9d ("hw/mips/jazz: use qemu_find_nic_info()") contained a typo
> in the NIC alias which caused initialisation of the in-built dp83932 NIC to fail
> when using the normal -nic user,model=dp83932 command line.
>
Cc: qemu-stable@nongnu.org # v9.0
Fixes: e104edbb9d ("hw/mips/jazz: use qemu_find_nic_info()")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> hw/mips/jazz.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/mips/jazz.c b/hw/mips/jazz.c
> index 1bc17e69d3..0d44e19707 100644
> --- a/hw/mips/jazz.c
> +++ b/hw/mips/jazz.c
> @@ -128,7 +128,7 @@ static void mips_jazz_init_net(IOMMUMemoryRegion *rc4030_dma_mr,
> uint8_t *prom;
> NICInfo *nd;
>
> - nd = qemu_find_nic_info("dp8393x", true, "dp82932");
> + nd = qemu_find_nic_info("dp8393x", true, "dp83932");
> if (!nd) {
> return;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [EXTERNAL] [PATCH] hw/mips/jazz: fix typo in in-built NIC alias
2024-09-07 4:08 ` Philippe Mathieu-Daudé
@ 2024-09-07 9:25 ` David Woodhouse
0 siblings, 0 replies; 4+ messages in thread
From: David Woodhouse @ 2024-09-07 9:25 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Mark Cave-Ayland, hpoussin, arikalo,
jiaxun.yang, qemu-devel, qemu-stable
[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]
On Sat, 2024-09-07 at 06:08 +0200, Philippe Mathieu-Daudé wrote:
> On 7/9/24 01:01, Mark Cave-Ayland wrote:
> > Commit e104edbb9d ("hw/mips/jazz: use qemu_find_nic_info()") contained a typo
> > in the NIC alias which caused initialisation of the in-built dp83932 NIC to fail
> > when using the normal -nic user,model=dp83932 command line.
> >
>
> Cc: qemu-stable@nongnu.org # v9.0
> Fixes: e104edbb9d ("hw/mips/jazz: use qemu_find_nic_info()")
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
Thanks.
> > Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> > ---
> > hw/mips/jazz.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/mips/jazz.c b/hw/mips/jazz.c
> > index 1bc17e69d3..0d44e19707 100644
> > --- a/hw/mips/jazz.c
> > +++ b/hw/mips/jazz.c
> > @@ -128,7 +128,7 @@ static void mips_jazz_init_net(IOMMUMemoryRegion *rc4030_dma_mr,
> > uint8_t *prom;
> > NICInfo *nd;
> >
> > - nd = qemu_find_nic_info("dp8393x", true, "dp82932");
> > + nd = qemu_find_nic_info("dp8393x", true, "dp83932");
> > if (!nd) {
> > return;
> > }
>
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/mips/jazz: fix typo in in-built NIC alias
2024-09-06 23:01 [PATCH] hw/mips/jazz: fix typo in in-built NIC alias Mark Cave-Ayland
2024-09-07 4:08 ` Philippe Mathieu-Daudé
@ 2024-09-07 12:11 ` Michael Tokarev
1 sibling, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2024-09-07 12:11 UTC (permalink / raw)
To: Mark Cave-Ayland, hpoussin, arikalo, philmd, jiaxun.yang, dwmw,
qemu-devel, qemu-stable, QEMU Trivial
07.09.2024 02:01, Mark Cave-Ayland wrote:
> Commit e104edbb9d ("hw/mips/jazz: use qemu_find_nic_info()") contained a typo
> in the NIC alias which caused initialisation of the in-built dp83932 NIC to fail
> when using the normal -nic user,model=dp83932 command line.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
This is a fun one indeed :)
I picked this one up to qemu-trivial tree, if no one picks it before.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-09-07 12:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-06 23:01 [PATCH] hw/mips/jazz: fix typo in in-built NIC alias Mark Cave-Ayland
2024-09-07 4:08 ` Philippe Mathieu-Daudé
2024-09-07 9:25 ` [EXTERNAL] " David Woodhouse
2024-09-07 12:11 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).