From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: "Cédric Le Goater" <clg@kaod.org>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Greg Kurz" <groug@kaod.org>,
qemu-ppc@nongnu.org
Subject: Re: [PATCH v2 17/25] target/ppc: Avoid tcg_const_* in vsx-impl.c.inc
Date: Tue, 7 Mar 2023 18:42:55 -0300 [thread overview]
Message-ID: <5f513af2-30da-fd38-2c56-894cd149ce65@gmail.com> (raw)
In-Reply-To: <20230307183503.2512684-18-richard.henderson@linaro.org>
On 3/7/23 15:34, Richard Henderson wrote:
> All remaining uses are strictly read-only.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> Cc: Daniel Henrique Barboza <danielhb413@gmail.com>
> Cc: Cédric Le Goater <clg@kaod.org>
> Cc: David Gibson <david@gibson.dropbear.id.au>
> Cc: Greg Kurz <groug@kaod.org>
> Cc: qemu-ppc@nongnu.org
> ---
> target/ppc/translate/vsx-impl.c.inc | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/target/ppc/translate/vsx-impl.c.inc b/target/ppc/translate/vsx-impl.c.inc
> index 9916784e64..0f5b0056f1 100644
> --- a/target/ppc/translate/vsx-impl.c.inc
> +++ b/target/ppc/translate/vsx-impl.c.inc
> @@ -154,7 +154,7 @@ static void gen_lxvdsx(DisasContext *ctx)
> static void gen_bswap16x8(TCGv_i64 outh, TCGv_i64 outl,
> TCGv_i64 inh, TCGv_i64 inl)
> {
> - TCGv_i64 mask = tcg_const_i64(0x00FF00FF00FF00FF);
> + TCGv_i64 mask = tcg_constant_i64(0x00FF00FF00FF00FF);
> TCGv_i64 t0 = tcg_temp_new_i64();
> TCGv_i64 t1 = tcg_temp_new_i64();
>
> @@ -825,7 +825,7 @@ static bool trans_XSCVQPDP(DisasContext *ctx, arg_X_tb_rc *a)
> REQUIRE_INSNS_FLAGS2(ctx, ISA300);
> REQUIRE_VSX(ctx);
>
> - ro = tcg_const_i32(a->rc);
> + ro = tcg_constant_i32(a->rc);
>
> xt = gen_avr_ptr(a->rt);
> xb = gen_avr_ptr(a->rb);
> @@ -860,7 +860,7 @@ static void gen_##name(DisasContext *ctx) \
> gen_exception(ctx, POWERPC_EXCP_VSXU); \
> return; \
> } \
> - opc = tcg_const_i32(ctx->opcode); \
> + opc = tcg_constant_i32(ctx->opcode); \
> gen_helper_##name(cpu_env, opc); \
> }
>
> @@ -900,7 +900,7 @@ static void gen_##name(DisasContext *ctx) \
> gen_exception(ctx, POWERPC_EXCP_VSXU); \
> return; \
> } \
> - opc = tcg_const_i32(ctx->opcode); \
> + opc = tcg_constant_i32(ctx->opcode); \
> xa = gen_vsr_ptr(xA(ctx->opcode)); \
> xb = gen_vsr_ptr(xB(ctx->opcode)); \
> gen_helper_##name(cpu_env, opc, xa, xb); \
> @@ -915,7 +915,7 @@ static void gen_##name(DisasContext *ctx) \
> gen_exception(ctx, POWERPC_EXCP_VSXU); \
> return; \
> } \
> - opc = tcg_const_i32(ctx->opcode); \
> + opc = tcg_constant_i32(ctx->opcode); \
> xb = gen_vsr_ptr(xB(ctx->opcode)); \
> gen_helper_##name(cpu_env, opc, xb); \
> }
> @@ -929,7 +929,7 @@ static void gen_##name(DisasContext *ctx) \
> gen_exception(ctx, POWERPC_EXCP_VSXU); \
> return; \
> } \
> - opc = tcg_const_i32(ctx->opcode); \
> + opc = tcg_constant_i32(ctx->opcode); \
> xt = gen_vsr_ptr(rD(ctx->opcode) + 32); \
> xa = gen_vsr_ptr(rA(ctx->opcode) + 32); \
> xb = gen_vsr_ptr(rB(ctx->opcode) + 32); \
> @@ -945,7 +945,7 @@ static void gen_##name(DisasContext *ctx) \
> gen_exception(ctx, POWERPC_EXCP_VSXU); \
> return; \
> } \
> - opc = tcg_const_i32(ctx->opcode); \
> + opc = tcg_constant_i32(ctx->opcode); \
> xt = gen_vsr_ptr(rD(ctx->opcode) + 32); \
> xb = gen_vsr_ptr(rB(ctx->opcode) + 32); \
> gen_helper_##name(cpu_env, opc, xt, xb); \
> @@ -960,7 +960,7 @@ static void gen_##name(DisasContext *ctx) \
> gen_exception(ctx, POWERPC_EXCP_VSXU); \
> return; \
> } \
> - opc = tcg_const_i32(ctx->opcode); \
> + opc = tcg_constant_i32(ctx->opcode); \
> xa = gen_vsr_ptr(rA(ctx->opcode) + 32); \
> xb = gen_vsr_ptr(rB(ctx->opcode) + 32); \
> gen_helper_##name(cpu_env, opc, xa, xb); \
> @@ -1994,8 +1994,8 @@ static void gen_xsxsigdp(DisasContext *ctx)
> exp = tcg_temp_new_i64();
> t0 = tcg_temp_new_i64();
> t1 = tcg_temp_new_i64();
> - zr = tcg_const_i64(0);
> - nan = tcg_const_i64(2047);
> + zr = tcg_constant_i64(0);
> + nan = tcg_constant_i64(2047);
>
> get_cpu_vsr(t1, xB(ctx->opcode), true);
> tcg_gen_extract_i64(exp, t1, 52, 11);
> @@ -2026,8 +2026,8 @@ static void gen_xsxsigqp(DisasContext *ctx)
> get_cpu_vsr(xbl, rB(ctx->opcode) + 32, false);
> exp = tcg_temp_new_i64();
> t0 = tcg_temp_new_i64();
> - zr = tcg_const_i64(0);
> - nan = tcg_const_i64(32767);
> + zr = tcg_constant_i64(0);
> + nan = tcg_constant_i64(32767);
>
> tcg_gen_extract_i64(exp, xbh, 48, 15);
> tcg_gen_movi_i64(t0, 0x0001000000000000);
> @@ -2193,8 +2193,8 @@ static void gen_xvxsigdp(DisasContext *ctx)
> get_cpu_vsr(xbl, xB(ctx->opcode), false);
> exp = tcg_temp_new_i64();
> t0 = tcg_temp_new_i64();
> - zr = tcg_const_i64(0);
> - nan = tcg_const_i64(2047);
> + zr = tcg_constant_i64(0);
> + nan = tcg_constant_i64(2047);
>
> tcg_gen_extract_i64(exp, xbh, 52, 11);
> tcg_gen_movi_i64(t0, 0x0010000000000000);
next prev parent reply other threads:[~2023-03-07 21:43 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 18:34 [PATCH v2 00/25] tcg: Remove tcg_const_* Richard Henderson
2023-03-07 18:34 ` [PATCH v2 01/25] target/arm: Use rmode >= 0 for need_rmode Richard Henderson
2023-03-07 18:34 ` [PATCH v2 02/25] target/arm: Handle FPROUNDING_ODD in arm_rmode_to_sf Richard Henderson
2023-03-08 17:25 ` Philippe Mathieu-Daudé
2023-03-07 18:34 ` [PATCH v2 03/25] target/arm: Improve arm_rmode_to_sf Richard Henderson
2023-03-07 18:34 ` [PATCH v2 04/25] target/arm: Consistently use ARMFPRounding during translation Richard Henderson
2023-03-07 18:34 ` [PATCH v2 05/25] target/arm: Create gen_set_rmode, gen_restore_rmode Richard Henderson
2023-03-09 9:48 ` Philippe Mathieu-Daudé
2023-03-07 18:34 ` [PATCH v2 06/25] target/arm: Improve trans_BFCI Richard Henderson
2023-03-07 23:05 ` Philippe Mathieu-Daudé
2023-03-07 18:34 ` [PATCH v2 07/25] target/arm: Avoid tcg_const_ptr in gen_sve_{ldr, str} Richard Henderson
2023-03-07 18:34 ` [PATCH v2 08/25] target/arm: Avoid tcg_const_* in translate-mve.c Richard Henderson
2023-03-09 13:27 ` Philippe Mathieu-Daudé
2023-03-07 18:34 ` [PATCH v2 09/25] target/arm: Avoid tcg_const_ptr in disas_simd_zip_trn Richard Henderson
2023-03-07 23:02 ` Philippe Mathieu-Daudé
2023-03-07 18:34 ` [PATCH v2 10/25] target/arm: Avoid tcg_const_ptr in handle_vec_simd_sqshrn Richard Henderson
2023-03-07 18:34 ` [PATCH v2 11/25] target/arm: Avoid tcg_const_ptr in handle_rev Richard Henderson
2023-03-07 18:34 ` [PATCH v2 12/25] target/m68k: Reject immediate as destination in gen_ea_mode Richard Henderson
2023-03-09 12:32 ` Laurent Vivier
2023-03-09 16:27 ` Richard Henderson
2023-03-07 18:34 ` [PATCH v2 13/25] target/m68k: Use tcg_constant_i32 " Richard Henderson
2023-03-07 18:34 ` [PATCH v2 14/25] target/ppc: Avoid tcg_const_i64 in do_vcntmb Richard Henderson
2023-03-07 21:42 ` Daniel Henrique Barboza
2023-03-09 10:18 ` Philippe Mathieu-Daudé
2023-03-07 18:34 ` [PATCH v2 15/25] target/ppc: Avoid tcg_const_* in vmx-impl.c.inc Richard Henderson
2023-03-07 21:42 ` Daniel Henrique Barboza
2023-03-09 9:49 ` Philippe Mathieu-Daudé
2023-03-07 18:34 ` [PATCH v2 16/25] target/ppc: Avoid tcg_const_* in xxeval Richard Henderson
2023-03-07 21:42 ` Daniel Henrique Barboza
2023-03-09 9:51 ` Philippe Mathieu-Daudé
2023-03-07 18:34 ` [PATCH v2 17/25] target/ppc: Avoid tcg_const_* in vsx-impl.c.inc Richard Henderson
2023-03-07 21:42 ` Daniel Henrique Barboza [this message]
2023-03-09 9:52 ` Philippe Mathieu-Daudé
2023-03-07 18:34 ` [PATCH v2 18/25] target/ppc: Avoid tcg_const_* in fp-impl.c.inc Richard Henderson
2023-03-07 21:43 ` Daniel Henrique Barboza
2023-03-09 9:54 ` Philippe Mathieu-Daudé
2023-03-07 18:34 ` [PATCH v2 19/25] target/ppc: Avoid tcg_const_* in power8-pmu-regs.c.inc Richard Henderson
2023-03-07 21:43 ` Daniel Henrique Barboza
2023-03-09 9:54 ` Philippe Mathieu-Daudé
2023-03-07 18:34 ` [PATCH v2 20/25] target/ppc: Rewrite trans_ADDG6S Richard Henderson
2023-03-07 21:51 ` Daniel Henrique Barboza
2023-03-07 22:34 ` Richard Henderson
2023-03-07 18:34 ` [PATCH v2 21/25] target/ppc: Fix gen_tlbsx_booke206 Richard Henderson
2023-03-07 21:44 ` Daniel Henrique Barboza
2023-03-07 18:35 ` [PATCH v2 22/25] target/ppc: Avoid tcg_const_* in translate.c Richard Henderson
2023-03-07 21:44 ` Daniel Henrique Barboza
2023-03-09 10:02 ` Philippe Mathieu-Daudé
2023-03-07 18:35 ` [PATCH v2 23/25] target/tricore: Use min/max for saturate Richard Henderson
2023-03-09 10:09 ` Philippe Mathieu-Daudé
2023-03-07 18:35 ` [PATCH v2 24/25] tcg: Drop tcg_const_*_vec Richard Henderson
2023-03-07 18:35 ` [PATCH v2 25/25] tcg: Drop tcg_const_* Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f513af2-30da-fd38-2c56-894cd149ce65@gmail.com \
--to=danielhb413@gmail.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).