From: Eric Blake <eblake@redhat.com>
To: Edgar Kaziakhmedov <edgar.kaziakhmedov@virtuozzo.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, mreitz@redhat.com,
den@openvz.org, vsementsov@virtuozzo.com
Subject: Re: [Qemu-devel] [PATCH 1/1] nbd: implement bdrv_get_info callback
Date: Fri, 2 Feb 2018 08:15:50 -0600 [thread overview]
Message-ID: <5f76135f-6a96-6446-7f48-0683e7674c32@redhat.com> (raw)
In-Reply-To: <4919379e-ee86-5032-ec1e-fea39912783b@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
On 02/02/2018 08:06 AM, Edgar Kaziakhmedov wrote:
>>>> However, it would be nice to remove can_write_zeroes_with_unmap from
>>>> BlockDriverInfo, and make bdrv_can_write_zeroes_with_unmap just return
>>>> !!(bs->supported_zero_flags & BDRV_REQ_MAY_UNMAP). Kevin, what do you
>>>> think?
>> Actually, I may even just give a shot at writing this alternative patch,
>> to make Kevin's decision easier.
> But actually qcow2 performs some checks for version inside get_info
> callback before setting can_write_zeroes_with_unmap flag,
> so we can't take into account such checks in
> bdrv_can_write_zeroes_with_unmap subroutine. Therefore, I don't think it
> is possible to do it like that.
Here's the patch I proposed (it looks like I forgot to CC you):
https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg06471.html
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2018-02-02 14:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 11:51 [Qemu-devel] [PATCH 1/1] nbd: implement bdrv_get_info callback Edgar Kaziakhmedov
2018-01-18 12:09 ` Paolo Bonzini
2018-01-26 12:39 ` Edgar Kaziakhmedov
2018-01-26 14:28 ` Eric Blake
2018-02-02 14:06 ` Edgar Kaziakhmedov
2018-02-02 14:15 ` Eric Blake [this message]
2018-02-02 14:23 ` Edgar Kaziakhmedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f76135f-6a96-6446-7f48-0683e7674c32@redhat.com \
--to=eblake@redhat.com \
--cc=den@openvz.org \
--cc=edgar.kaziakhmedov@virtuozzo.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).