qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
	qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] trivial: Make bios files and source files non-executable
Date: Wed, 13 Jun 2018 12:34:45 +0200	[thread overview]
Message-ID: <5f7eaa02-8dc6-9d61-0a30-62d632f6cda3@redhat.com> (raw)
In-Reply-To: <1528867465-26696-1-git-send-email-thuth@redhat.com>

On 13.06.2018 07:24, Thomas Huth wrote:
> These files can not be executed on the host, so they should not be
> marked as executable.

Or can not be executed at all :)

Reviewed-by: David Hildenbrand <david@redhat.com>

> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  block/blkreplay.c                  |   0
>  pc-bios/hppa-firmware.img          | Bin
>  pc-bios/palcode-clipper            | Bin
>  pc-bios/u-boot-sam460-20100605.bin | Bin
>  pc-bios/u-boot.e500                | Bin
>  replay/replay-char.c               |   0
>  6 files changed, 0 insertions(+), 0 deletions(-)
>  mode change 100755 => 100644 block/blkreplay.c
>  mode change 100755 => 100644 pc-bios/hppa-firmware.img
>  mode change 100755 => 100644 pc-bios/palcode-clipper
>  mode change 100755 => 100644 pc-bios/u-boot-sam460-20100605.bin
>  mode change 100755 => 100644 pc-bios/u-boot.e500
>  mode change 100755 => 100644 replay/replay-char.c
> 
> diff --git a/block/blkreplay.c b/block/blkreplay.c
> old mode 100755
> new mode 100644
> diff --git a/pc-bios/hppa-firmware.img b/pc-bios/hppa-firmware.img
> old mode 100755
> new mode 100644
> diff --git a/pc-bios/palcode-clipper b/pc-bios/palcode-clipper
> old mode 100755
> new mode 100644
> diff --git a/pc-bios/u-boot-sam460-20100605.bin b/pc-bios/u-boot-sam460-20100605.bin
> old mode 100755
> new mode 100644
> diff --git a/pc-bios/u-boot.e500 b/pc-bios/u-boot.e500
> old mode 100755
> new mode 100644
> diff --git a/replay/replay-char.c b/replay/replay-char.c
> old mode 100755
> new mode 100644
> 


-- 

Thanks,

David / dhildenb

  reply	other threads:[~2018-06-13 10:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13  5:24 [Qemu-devel] [PATCH] trivial: Make bios files and source files non-executable Thomas Huth
2018-06-13 10:34 ` David Hildenbrand [this message]
2018-08-24  5:05   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f7eaa02-8dc6-9d61-0a30-62d632f6cda3@redhat.com \
    --to=david@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).