RE: [RFC v7 26/26] vfio/pci: Implement return_page_response page response callback

[Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>]

Hi Eric,

> -----Original Message-----
> From: Auger Eric [mailto:eric.auger@redhat.com]
> Sent: 18 February 2021 10:42
> To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>;
> eric.auger.pro@gmail.com; qemu-devel@nongnu.org; qemu-arm@nongnu.org;
> alex.williamson@redhat.com
> Cc: peter.maydell@linaro.org; jacob.jun.pan@linux.intel.com; Zengtao (B)
> <prime.zeng@hisilicon.com>; jean-philippe@linaro.org; tn@semihalf.com;
> peterx@redhat.com; nicoleotsuka@gmail.com; vivek.gautam@arm.com;
> yi.l.liu@intel.com; zhangfei.gao@gmail.com; yuzenghui
> <yuzenghui@huawei.com>; qubingbing <qubingbing@hisilicon.com>
> Subject: Re: [RFC v7 26/26] vfio/pci: Implement return_page_response page
> response callback
> 
[...]

> > Also, I just noted that this patch breaks the dev hot add/del functionality.
> > device_add works fine but device_del is not removing the dev cleanly.Thank
> you for reporting this!
> 
> The test matrix becomes bigger and bigger :-( I Need to write some
> avocado-vt tests or alike.
> 
> I am currently working on the respin. At the moment I investigate the
> DPDK issue that you reported and I was able to reproduce.

Ok. Good to know that it is reproducible.

> I intend to rebase on top of Jean-Philippe's
> [PATCH v12 00/10] iommu: I/O page faults for SMMUv3
> 
> Is that good enough for your SVA integration or do you want I prepare a
> rebase on some extended code?

Could you please try to base it on https://jpbrucker.net/git/linux/log/?h=sva/current

I think that has the latest from Jean-Philippe and will be easy to add
uacce/zip specific patches to test SVA/vSVA.

Thanks,
Shameer

 
> Thanks
> 
> Eric
> >
> > The below one fixes it. Please check.
> >
> > Thanks,
> > Shameer
> >
> > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> > index 797acd9c73..92c1d48316 100644
> > --- a/hw/vfio/pci.c
> > +++ b/hw/vfio/pci.c
> > @@ -3470,6 +3470,7 @@ static void vfio_instance_finalize(Object *obj)
> >      vfio_display_finalize(vdev);
> >      vfio_bars_finalize(vdev);
> >      vfio_region_finalize(&vdev->dma_fault_region);
> > +    vfio_region_finalize(&vdev->dma_fault_response_region);
> >      g_free(vdev->emulated_config_bits);
> >      g_free(vdev->rom);
> >      /*
> > @@ -3491,6 +3492,7 @@ static void vfio_exitfn(PCIDevice *pdev)
> >      vfio_unregister_err_notifier(vdev);
> >      vfio_unregister_ext_irq_notifiers(vdev);
> >      vfio_region_exit(&vdev->dma_fault_region);
> > +    vfio_region_exit(&vdev->dma_fault_response_region);
> >      pci_device_set_intx_routing_notifier(&vdev->pdev, NULL);
> >      if (vdev->irqchip_change_notifier.notify) {
> >
> kvm_irqchip_remove_change_notifier(&vdev->irqchip_change_not
> >
> >
> >