From: Laszlo Ersek <lersek@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org,
qemu-block@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 2/2] Makefile: Derive "PKGVERSION" from "git describe" by default
Date: Wed, 1 Jun 2016 13:13:08 +0200 [thread overview]
Message-ID: <5f939153-1f8e-105e-c277-94f84a44b0a8@redhat.com> (raw)
In-Reply-To: <1464777632.8823.22.camel@redhat.com>
On 06/01/16 12:40, Gerd Hoffmann wrote:
> Hi,
>
>> + git describe 2>/dev/null | tr -d '\n'; \
>> + if ! git diff-index --quiet HEAD &>/dev/null; then \
>> + printf -- '-dirty'; \
>> + fi \
>
> /me suggests "git describe --dirty --match 'v*'"
>
> Saves the extra effort to check for a dirty tree manually.
We couldn't convince ourselves that support for "--dirty" is ubiquitous;
please see the sub-thread rooted at
<http://thread.gmane.org/gmane.comp.emulators.qemu/414824/focus=414828>.
> Also greatly reduces the chance non-release tags are matched, so I don't
> get results like "pull-vga-20160523-1-236-g9fd5eb7".
Since what version is "--match" supported? ;)
Thanks
Laszlo
next prev parent reply other threads:[~2016-06-01 11:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 9:44 [Qemu-devel] [PATCH v3 0/2] Let PKGVERSION include the "git describe" output Fam Zheng
2016-06-01 9:44 ` [Qemu-devel] [PATCH v3 1/2] Makefile: Add a "FORCE" target Fam Zheng
2016-06-01 10:12 ` Daniel P. Berrange
2016-06-01 9:44 ` [Qemu-devel] [PATCH v3 2/2] Makefile: Derive "PKGVERSION" from "git describe" by default Fam Zheng
2016-06-01 10:13 ` Daniel P. Berrange
2016-06-01 10:40 ` Gerd Hoffmann
2016-06-01 11:13 ` Laszlo Ersek [this message]
2016-06-01 13:55 ` Paolo Bonzini
2016-06-01 15:30 ` Laszlo Ersek
2016-06-02 1:14 ` Fam Zheng
2016-06-20 4:50 ` [Qemu-devel] [PATCH v3 0/2] Let PKGVERSION include the "git describe" output Changlong Xie
2016-06-20 8:05 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f939153-1f8e-105e-c277-94f84a44b0a8@redhat.com \
--to=lersek@redhat.com \
--cc=famz@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).