From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51844)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1b845R-00066V-1Q
	for qemu-devel@nongnu.org; Wed, 01 Jun 2016 07:13:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1b845O-0006yO-TZ
	for qemu-devel@nongnu.org; Wed, 01 Jun 2016 07:13:19 -0400
References: <1464774261-648-1-git-send-email-famz@redhat.com>
	<1464774261-648-3-git-send-email-famz@redhat.com>
	<1464777632.8823.22.camel@redhat.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <5f939153-1f8e-105e-c277-94f84a44b0a8@redhat.com>
Date: Wed, 1 Jun 2016 13:13:08 +0200
MIME-Version: 1.0
In-Reply-To: <1464777632.8823.22.camel@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 2/2] Makefile: Derive "PKGVERSION" from
 "git describe" by default
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>, Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, qemu-block@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>

On 06/01/16 12:40, Gerd Hoffmann wrote:
>   Hi,
> 
>> +				git describe 2>/dev/null | tr -d '\n'; \
>> +				if ! git diff-index --quiet HEAD &>/dev/null; then \
>> +					printf -- '-dirty'; \
>> +				fi \
> 
> /me suggests "git describe --dirty --match 'v*'"
> 
> Saves the extra effort to check for a dirty tree manually.

We couldn't convince ourselves that support for "--dirty" is ubiquitous;
please see the sub-thread rooted at
<http://thread.gmane.org/gmane.comp.emulators.qemu/414824/focus=414828>.

> Also greatly reduces the chance non-release tags are matched, so I don't
> get results like "pull-vga-20160523-1-236-g9fd5eb7".

Since what version is "--match" supported? ;)

Thanks
Laszlo