From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26DB0C3DA5D for ; Tue, 23 Jul 2024 01:15:16 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sW475-00067d-W0; Mon, 22 Jul 2024 21:14:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sW474-00063N-PT for qemu-devel@nongnu.org; Mon, 22 Jul 2024 21:14:46 -0400 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sW473-0001gm-2W for qemu-devel@nongnu.org; Mon, 22 Jul 2024 21:14:46 -0400 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1fd69e44596so2228585ad.1 for ; Mon, 22 Jul 2024 18:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721697283; x=1722302083; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xkTaHaVwx0wmRUpXj0kKUkOvHZTx2SEVkZ1HphGDHEg=; b=N/32yjXNQSxaSNbQAu/+sWkN3kRDlayYUTyCv8NFpdAvrIxBCmzzeSfe7BbCxxveqC 3grdCrPWo0nzymyCBxyT4pkaFgxDnv+vWJRvikGyAkJ5UTfkYqCk4YMVLSARvWbXhIqS bEBj4TndHklTkvtcTulzldCDXR6No8nglXlD1SIp4BV+KecHVLi1c9iJB87zoOivRpab Ctv4rA3zC/85/C8P0LKWz5BiS+elCofr2dPsar0zRvtFkHraYm6eFKZSK44yptYLBO53 1Tf78q/ScCgcMuhf/AvG5zmYpo939xcbMwFuyyoWyZx49WHlsV8g4ylqRsBOIaymLXTk 8gJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721697283; x=1722302083; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xkTaHaVwx0wmRUpXj0kKUkOvHZTx2SEVkZ1HphGDHEg=; b=Rt3vRH07drra3DyTdxAeYESPFxGzXDERCyf8/ziWPaANr+udOspMaZqZyU/47rs8nr Oc6rl5665RoDGpJgREHHCj79Zry85Brm+SLnayj+JtLSllAO6cQph1sDfGdvQU8eWwOr NyUjiyDhbFLTeUhyIkpf4iaAAB53GO502/MxNi8lmvT4f+P6RsCcPOzXwpAwnhYdQqSf BFEkZpxJQB40BX3NOot5kJf27hsQkYgAWBxCSk9gIDv8cOZvgKaLBlSjyF98ySni23pC oZjBWhnbrHZXAmwbURoaX7VFkoiLmIsLrTQ+fzsqPmExNAbqZnGy0Inh+JFalxqOQ0Ul 7rpQ== X-Forwarded-Encrypted: i=1; AJvYcCXOF6o+V5dMP2/4j8if4fBGFig7VC/a///5zCWh/IA+pqf48GGDFMRduiefCPpp29BbiUKC+UJ4mWF9XEYXvO7Kug+qVhs= X-Gm-Message-State: AOJu0YzJO4fm8cWP51lErfIgSPelT7DnliKv83iOXoUvPqmfDTIJhq3e WdBasdJ4uAZsRXhwwKGQZcHMQMM4caY4ndScZxsHa/MvLS+qF9tmdIq1VKe9zzE= X-Google-Smtp-Source: AGHT+IFpn8uExj8ENjR2tBqrIKwOrIMtju7uTLA3Ivm/qUxVZ+QSCi14NMRYu7p59xIP/9LE6iZ6Zw== X-Received: by 2002:a17:902:e881:b0:1fd:71cd:4431 with SMTP id d9443c01a7336-1fdb9581b6emr9639715ad.24.1721697283326; Mon, 22 Jul 2024 18:14:43 -0700 (PDT) Received: from [192.168.1.113] ([203.56.128.103]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fd6f2ac662sm61712825ad.115.2024.07.22.18.14.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jul 2024 18:14:42 -0700 (PDT) Message-ID: <5fa0906f-b732-4721-92b5-58649632e3df@linaro.org> Date: Tue, 23 Jul 2024 11:14:37 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/14] bsd-user: Define TARGET_SIGSTACK_ALIGN and use it to round stack To: Warner Losh , qemu-devel@nongnu.org Cc: Kyle Evans , qemu-arm@nongnu.org, Peter Maydell References: <20240722214313.89503-1-imp@bsdimp.com> <20240722214313.89503-13-imp@bsdimp.com> Content-Language: en-US From: Richard Henderson In-Reply-To: <20240722214313.89503-13-imp@bsdimp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 7/23/24 07:43, Warner Losh wrote: > Most (all?) targets require stacks to be properly aligned. Rather than a > series of ifdefs in bsd-user/signal.h, instead use a manditory #define > for all architectures. > > Signed-off-by: Warner Losh > --- > bsd-user/aarch64/target_arch_signal.h | 2 ++ > bsd-user/arm/target_arch_signal.h | 2 ++ > bsd-user/i386/target_arch_signal.h | 2 ++ > bsd-user/signal.c | 9 +-------- > bsd-user/x86_64/target_arch_signal.h | 2 ++ > 5 files changed, 9 insertions(+), 8 deletions(-) Reviewed-by: Richard Henderson r~