From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40C88C04AB5 for ; Mon, 3 Jun 2019 10:58:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DA56280E4 for ; Mon, 3 Jun 2019 10:58:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DA56280E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:33104 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXkfo-0007jb-AI for qemu-devel@archiver.kernel.org; Mon, 03 Jun 2019 06:58:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45215) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXkez-0007Sv-O7 for qemu-devel@nongnu.org; Mon, 03 Jun 2019 06:57:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hXkey-0000oV-K5 for qemu-devel@nongnu.org; Mon, 03 Jun 2019 06:57:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37724) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hXkey-0000mU-Cc for qemu-devel@nongnu.org; Mon, 03 Jun 2019 06:57:48 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7BA173082212; Mon, 3 Jun 2019 10:57:46 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-13.rdu2.redhat.com [10.10.121.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3F2491001E69; Mon, 3 Jun 2019 10:57:21 +0000 (UTC) To: Markus Armbruster , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <87lfyqla7r.fsf@dusky.pond.sub.org> <87sgsxpd01.fsf@dusky.pond.sub.org> From: Laszlo Ersek Message-ID: <5fabf029-e8d4-72ea-19c8-b516c49f2a57@redhat.com> Date: Mon, 3 Jun 2019 12:57:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87sgsxpd01.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Mon, 03 Jun 2019 10:57:47 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] Headers without multiple inclusion guards X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Dmitry Fleytman , Sagar Karandikar , "Michael S. Tsirkin" , James Hogan , Anthony Green , Palmer Dabbelt , Mark Cave-Ayland , qemu-devel@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Guan Xuetao , Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Helge Deller , David Hildenbrand , Halil Pasic , Christian Borntraeger , Anthony Perard , David Gibson , Jason Wang , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Alistair Francis , Eduardo Habkost , Riku Voipio , Greg Kurz , Marcelo Tosatti , Beniamino Galvani , Eric Auger , Paul Durrant , Stafford Horne , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Richard Henderson , "Daniel P. Berrange" , Claudio Fontana , Bastian Koppelmann , Chris Wulff , Claudio Fontana , Laurent Vivier , Andrew Baumann , Michael Walle , Aleksandar Markovic , Cornelia Huck , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 05/29/19 16:10, Markus Armbruster wrote: > Philippe Mathieu-Daud=C3=A9 writes: >=20 >> On 5/28/19 8:12 PM, Markus Armbruster wrote: >>> We have a bunch of headers without multiple inclusion guards. Some a= re >>> clearly intentional, some look accidental. Too many for me to find o= ut >>> by examining each of them, so I'm asking their maintainers. >>> >>> Why do I ask? I'd like to mark the intentional ones and fix the >>> accidental ones, so they don't flunk "make check-headers" from "[RFC = v4 >>> 0/7] Baby steps towards saner headers" just because they lack multipl= e >>> inclusion guards. >>> >>> Just in case: what's a multiple inclusion guard? It's >>> >>> #ifndef UNIQUE_GUARD_SYMBOL_H >>> #define UNIQUE_GUARD_SYMBOL_H >>> ... >>> #endif >>> >>> with nothing but comments outside the conditional, so that the header >>> can safely be included more than once. >>> >>> I append the alphabetical list of headers without multiple inclusion >>> guards (as reported by scripts/clean-header-guards -nv), followed by = the >>> same list sorted into maintainer buckets. If you're cc'ed, please fi= nd >>> your bucket(s), and tell me which headers intentionally lack guards. >>> >> [...] >>> >>> EDK2 Firmware >>> M: Laszlo Ersek >>> M: Philippe Mathieu-Daud=C3=A9 >>> tests/uefi-test-tools/UefiTestToolsPkg/Include/Guid/BiosTablesTest.h >> >> This file has a guard in non-standard formats: >> >> #ifndef __BIOS_TABLES_TEST_H__ >> #define __BIOS_TABLES_TEST_H__ >> ... >=20 > scripts/clean-header-guards.pl didn't recognize the guard due to the // > comment after the #endif. I fixed the script, then used it to clean up > this header. >=20 > Thanks! >=20 (Sorry, I've just replied to the thread starter, before seeing this subthread. I'm OK if the header file is cleaned up.)