From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A5D4C3A59E for ; Wed, 21 Aug 2019 23:54:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F446217F9 for ; Wed, 21 Aug 2019 23:54:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zqqM055e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F446217F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0aR8-0002DG-85 for qemu-devel@archiver.kernel.org; Wed, 21 Aug 2019 19:54:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51970) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0aQ9-0001FN-GU for qemu-devel@nongnu.org; Wed, 21 Aug 2019 19:53:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0aQ8-0005jd-CW for qemu-devel@nongnu.org; Wed, 21 Aug 2019 19:53:41 -0400 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:40557) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i0aQ8-0005ih-5G for qemu-devel@nongnu.org; Wed, 21 Aug 2019 19:53:40 -0400 Received: by mail-pl1-x641.google.com with SMTP id h3so2252307pls.7 for ; Wed, 21 Aug 2019 16:53:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BWhUoFGMnkuFVUSfFjxK/rkl3W9VTXI+CM0vz9DXaLo=; b=zqqM055e+J78XQAGErsfKHdEPEHb9c3NwBHv2flJLKb4jWe3tE8lMz2YiERgO4j6LP 1NJPSC4DOFgC/7vvxcPFryP0JdVTMuTdavDT855cEWUVO0enUI4zi6wNFG8h5KXU5T7t bRUEvVbAatdYwZiKN3VxlXZskZPlv0u6kVV5GyOtbsAlh/HKa9jZcgjDfkG+/XIM03S4 q4sUG0oh+0/BG49FqnCUUrJttv5DOsMCQPv8xjFuIYJNEJ0PQ2UW94Z1ycgwNd641cBs Qlf2N2Z/YsoHmZar2hQTXmp1uv9QRQBUuv1dqYS4BC4kkHY6R5M1dvE8gnBevg7QTOKl NOqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BWhUoFGMnkuFVUSfFjxK/rkl3W9VTXI+CM0vz9DXaLo=; b=E1xTEXa2cKWfYOom2QsBynYFhnaDuJ6A5pguIVyaJgwwBiZOFvPcIzcr3PWdbMtmmR qRSLS7o3ALhXIq4Xdu5P91DmnErXuiqBP3JMs4ZNIJ+iC1GYkutxrcITjuXmn/FewB+1 vplCQchI/X/YYAVr8Bgvo3IgpoQ/nSmZ7bQMy4fbpam8svhIJd/YA4JRUKae0F2s2PfB fSoXoCHVO/Ccl+GB4NOAKvRZKpngZB0Ctrsz6haIt6eHcIPioLzIbxD15NOcLHl3hTJp v+oMzd1X4rCVzuOZHBd8JES8W9riglQQLP3sH704VJJt7YW2KED23VWIgcLdYbO+A2x9 aOUQ== X-Gm-Message-State: APjAAAUS5DfHboVy/qz5NBDvjz3CjyCkIF7FOCZC3D+7wlc1C3rKWSJ2 RxEhzShjuT2beaxXo9tuQwkI1A== X-Google-Smtp-Source: APXvYqwpI/T+IQ/GSgIca5P2HxnNHPpYyfUMtVlYPtUqjfe5UU7lhOd+Y1460+RlTYlQTr6LUQM5OA== X-Received: by 2002:a17:902:9f8e:: with SMTP id g14mr36830483plq.67.1566431618927; Wed, 21 Aug 2019 16:53:38 -0700 (PDT) Received: from [192.168.1.11] (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id d189sm31171157pfd.165.2019.08.21.16.53.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Aug 2019 16:53:37 -0700 (PDT) To: Jan Bobek , qemu-devel@nongnu.org References: <20190821172951.15333-1-jan.bobek@gmail.com> <20190821172951.15333-76-jan.bobek@gmail.com> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: <5fca852c-7824-ca02-8837-47979a509edd@linaro.org> Date: Wed, 21 Aug 2019 16:53:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190821172951.15333-76-jan.bobek@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::641 Subject: Re: [Qemu-devel] [RFC PATCH v4 75/75] target/i386: convert pmovmskb/movmskps/movmskpd helpers to gvec style X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/21/19 10:29 AM, Jan Bobek wrote: > + for (intptr_t i = 0; i * sizeof(uint8_t) < oprsz; ++i) { > + const uint8_t t = a->B(i) & (1 << 7); > + ret |= i < 8 ? t >> (7 - i) : t << (i - 7); You can avoid this variable shift by doing uint32_t t = a->B(i) >> 7; ret |= t << i; > +uint64_t glue(helper_pmovmskbq, SUFFIX)(Reg *a, uint32_t desc) > +{ > + return glue(helper_pmovmskbd, SUFFIX)(a, desc); > } ... > +DEF_GEN_INSN2_GVEC(vpmovmskb, Gd, Uqq, sd1_ool, XMM_OPRSZ, XMM_MAXSZ, pmovmskbd_xmm) > +DEF_GEN_INSN2_GVEC(vpmovmskb, Gq, Uqq, sq1_ool, XMM_OPRSZ, XMM_MAXSZ, pmovmskbq_xmm) What is the difference between these two? Given that we aren't attempting avx512, uint32_t is sufficient for all of the bytes of a YMM register. I have a feeling that some of this should simply use target_ulong, so that a direct assignment to the general register can be done without extra extensions within the generated code. r~