From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD9B2C02185 for ; Tue, 21 Jan 2025 08:06:48 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ta9Go-0005i6-Ez; Tue, 21 Jan 2025 03:05:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ta9Gg-0005h4-FN for qemu-devel@nongnu.org; Tue, 21 Jan 2025 03:05:52 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ta9Gb-0007bQ-9i for qemu-devel@nongnu.org; Tue, 21 Jan 2025 03:05:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737446741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RkqCCa9rWjKSdac+9OIK7ygSVkkapeD57SDL8zY+bW4=; b=HdOcgG0zenNd0cGF6BFtd5oqvheGaIm5Wteh4X51VA2C93FjBIcqp6P7TsxpvrHC5lpbjG ykDOKWXrJOwdB5VqMpZZhK7SOJc3mxo3WEzLkVMcEQtX3pJldpm5skFzcqckJ7q+BLdgGB jsKtKGScB/l57y7sSc2MU5qtPJWHKa4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-i0scRFZtPnSY3SWG5MUPgg-1; Tue, 21 Jan 2025 03:05:39 -0500 X-MC-Unique: i0scRFZtPnSY3SWG5MUPgg-1 X-Mimecast-MFC-AGG-ID: i0scRFZtPnSY3SWG5MUPgg Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-436379713baso25781085e9.2 for ; Tue, 21 Jan 2025 00:05:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737446738; x=1738051538; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=RkqCCa9rWjKSdac+9OIK7ygSVkkapeD57SDL8zY+bW4=; b=l/Nu6rirS6buKYyu2LF8NzzL0vvVmla1E6wFZSaTF+kId7PXNUsh0rUc1UaoL0RR7l +AQ107yTJz33SFE3Q/bHO+xfTnIQyzegDKLLZ72ez5Pg6hb5qy6e/MRmO+jkvTK3s636 eZTat+QC3OKXA7X5MFXjySsqLnBfSRG0uL/kvCUrin5YSO44kNBGRBJIW53Xgeov9Btp /4eebggub1vxrqjE03wReVR7aJXg7PIUufN3tdQSssjSnVuk9r07XzZWf3UdGfp8xmNB 1XK6RAaEKajg6d7pau7uUn0ffyYVm/vgMsPh/CJ1Vfe2Fy0SjIgBXtgHFnaJAcP2CnnV O7+Q== X-Gm-Message-State: AOJu0Yy5pYkABXpJnk0jEv9pnnxS6E4Z0BJOhbEsbwINw2vW9W24uSxJ U2YD1T5go+Mbl93tmONE4mYBqjZ0VMfBBye1Uhe5DCXWlsUwdevShOg/suwgZZEeSHrsyrDMs02 3XhkzNAIStw0ig1sG90rTJabIvf/mWG5wki5J9jQ1+7YpOQq4WLX5 X-Gm-Gg: ASbGnctwJGJptUnFCQBseGaH15HKZ5G4ma8hV2cjITUyxjNTitWOrzXSIneixmrt7rk 2cJXXsTwacAXdl81AP3h1POLW2t/fjcvAwEN9rpL6SBi6MftetNlqZw1d+h4eoa/CmZBDPbxqqI 3UZ/kA4qHAGkps5ysnH8SNjyeAopLzKkHUGlAS+E7CiBBg2zbAlMGODDsuOpwjvXxpiJUlOXnhb TN3lVmF0q3ZuCuSkEg0Rq3TBa3IN2DViG3AZy6S2spu9godGgVutjLpcCVTA8B+gLMbiOR8jW4T G+P/3oNEfN1dd9o0Ai64VaUFxvZ8dxeTHjRAavO/d88hYf25vRZpNSiarc3/xuN7QT9gfVC9yDW cuVZxZe1vESu5klFpG8c4XA== X-Received: by 2002:a05:600c:34c5:b0:434:b9c6:68f7 with SMTP id 5b1f17b1804b1-438914376bdmr127290225e9.26.1737446738239; Tue, 21 Jan 2025 00:05:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IH/56QP7oy2XagjWlfRwdmg4JPGPs679UZtDebv0qEpaQbL/M+1cI43KlaWF0irNGvpq8kZWg== X-Received: by 2002:a05:600c:34c5:b0:434:b9c6:68f7 with SMTP id 5b1f17b1804b1-438914376bdmr127290005e9.26.1737446737887; Tue, 21 Jan 2025 00:05:37 -0800 (PST) Received: from ?IPV6:2003:cb:c709:6200:16ba:af70:999d:6a1a? (p200300cbc709620016baaf70999d6a1a.dip0.t-ipconnect.de. [2003:cb:c709:6200:16ba:af70:999d:6a1a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c74c4e38sm227863345e9.21.2025.01.21.00.05.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jan 2025 00:05:36 -0800 (PST) Message-ID: <5fd5f718-ec08-4b38-827f-99d13bc7e225@redhat.com> Date: Tue, 21 Jan 2025 09:05:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/7] RAMBlock: make guest_memfd require coordinate discard To: Chenyi Qiang , Paolo Bonzini , Peter Xu , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Michael Roth Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Williams Dan J , Peng Chao P , Gao Chao , Xu Yilun References: <20241213070852.106092-1-chenyi.qiang@intel.com> <20241213070852.106092-7-chenyi.qiang@intel.com> <3e23b5b0-963c-4ca1-a26b-dd5f247a3a60@redhat.com> <46fcd4fd-999a-46ac-a268-e3651b94ef49@intel.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <46fcd4fd-999a-46ac-a268-e3651b94ef49@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-3, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.036, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 21.01.25 07:26, Chenyi Qiang wrote: > > > On 1/20/2025 9:11 PM, David Hildenbrand wrote: >> On 14.01.25 02:38, Chenyi Qiang wrote: >>> >>> >>> On 1/13/2025 6:56 PM, David Hildenbrand wrote: >>>> On 13.12.24 08:08, Chenyi Qiang wrote: >>>>> As guest_memfd is now managed by guest_memfd_manager with >>>>> RamDiscardManager, only block uncoordinated discard. >>>>> >>>>> Signed-off-by: Chenyi Qiang >>>>> --- >>>>>    system/physmem.c | 2 +- >>>>>    1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/system/physmem.c b/system/physmem.c >>>>> index 532182a6dd..585090b063 100644 >>>>> --- a/system/physmem.c >>>>> +++ b/system/physmem.c >>>>> @@ -1872,7 +1872,7 @@ static void ram_block_add(RAMBlock *new_block, >>>>> Error **errp) >>>>>            assert(kvm_enabled()); >>>>>            assert(new_block->guest_memfd < 0); >>>>>    -        ret = ram_block_discard_require(true); >>>>> +        ret = ram_block_coordinated_discard_require(true); >>>>>            if (ret < 0) { >>>>>                error_setg_errno(errp, -ret, >>>>>                                 "cannot set up private guest memory: >>>>> discard currently blocked"); >>>> >>>> Would that also unlock virtio-mem by accident? >>> >>> Hum, that's true. At present, the rdm in MR can only point to one >>> instance, thus if we unlock virtio-mem and try to use it with >>> guest_memfd, it would trigger assert in >>> memory_region_set_ram_discard_manager(). >>> >>> Maybe we need to add some explicit check in virtio-mem to exclude it >>> with guest_memfd at present? >> >> Likely we should make memory_region_set_ram_discard_manager() fail if >> there is already something, and handle it in the callers? >> >> In case of virtio-mem, we'd have to undo what we did and fail realize(). >> >> In case of CC, we'd have to bail out in a different way. >> >> >> Then, I think if we see new_block->guest_memfd here, that we can assume >> that any coordinated discard corresponds to only the guest_memfd one, >> not to anything else? > > LGTM. In case of CC, I think we can also check the > memory_region_set_ram_discard_manager() failure, undo what we did and > make the ram_block_add() fail (set errno). As we have memory_region_has_ram_discard_manager(), we could also check that instead of failing memory_region_set_ram_discard_manager(). But failing memory_region_set_ram_discard_manager() will force everybody to handle that, so it might be the better choice. Of course, setting it to "NULL" should be guaranteed to never fail. -- Cheers, David / dhildenb