From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au
Subject: Re: [PATCH v13 4/4] target/ppc: trigger PERFM EBBs from power8-pmu.c
Date: Fri, 25 Feb 2022 07:10:13 -0300 [thread overview]
Message-ID: <5fd7ee92-0e65-6d16-8b49-a1c209a48aff@gmail.com> (raw)
In-Reply-To: <46d03746-80a0-f7c5-54b8-fbdd4b13c132@linaro.org>
On 2/24/22 18:45, Richard Henderson wrote:
> On 2/24/22 10:19, Daniel Henrique Barboza wrote:
>> +void helper_ebb_perfm_excp(CPUPPCState *env)
>
> Please reserve the prefix "helper_" for something that is called from tcg generated code, which this is not.
The prefix is due to the fact that this is being declared as a translation
helper in target/ppc/helper.h, which is also part of the problem you mentioned.
I'll rename the function and not declare it as a translation helper.
Thanks,
Daniel
>
>
> r~
prev parent reply other threads:[~2022-02-25 10:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 20:18 [PATCH v13 0/4] PMU-EBB support for PPC64 TCG Daniel Henrique Barboza
2022-02-24 20:18 ` [PATCH v13 1/4] target/ppc: make power8-pmu.c CONFIG_TCG only Daniel Henrique Barboza
2022-02-24 21:32 ` Richard Henderson
2022-02-24 20:18 ` [PATCH v13 2/4] target/ppc: finalize pre-EBB PMU logic Daniel Henrique Barboza
2022-02-24 20:18 ` [PATCH v13 3/4] target/ppc: add PPC_INTERRUPT_EBB and EBB exceptions Daniel Henrique Barboza
2022-02-24 20:19 ` [PATCH v13 4/4] target/ppc: trigger PERFM EBBs from power8-pmu.c Daniel Henrique Barboza
2022-02-24 21:45 ` Richard Henderson
2022-02-25 10:10 ` Daniel Henrique Barboza [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fd7ee92-0e65-6d16-8b49-a1c209a48aff@gmail.com \
--to=danielhb413@gmail.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).