From: Marcel Apfelbaum <marcel@redhat.com>
To: Yuval Shaia <yuval.shaia@oracle.com>, qemu-devel@nongnu.org
Cc: Michael Tsirkin <mst@redhat.com>
Subject: Re: [Qemu-devel] ihw/rdma: Implementation of Query QP verb
Date: Wed, 21 Mar 2018 14:53:00 +0200 [thread overview]
Message-ID: <5ff502e3-4623-a097-4b83-68b68d7a76aa@redhat.com> (raw)
In-Reply-To: <20180320190023.24077-1-yuval.shaia@oracle.com>
Hi Yuval,
On 20/03/2018 21:00, Yuval Shaia wrote:
> Please review implementation of Query QP verb which is needed by some RDMA
> applications.
>
> Patch #1: Implementation in rdma backend layer
> Patch #2: Add support to pvrdma device
>
> v0 -> v1:
> * Split to two patches, one for rdma and one for pvrdma
>
Actually previous version was V1, this one is V2 :)
Next time please add V2 (V3...) prefix and I suggest using --cover-letter
when using git format-patch/send email instead of manually
adding it.
> [PATCH v1 1/2] hw/rdma: Add Query QP operation
> [PATCH v1 2/2] hw/rdma: Add support for Query QP verb to pvrdma
Second patch should have maybe rdma/vmw since is VMware specific (next time)
>
I am thinking adding it to 2.12, it can be seen as a bug-fix, querying QP
is a basic operation the device should answer to.
Michael, sounds reasonable?
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Thanks,
Marcel
prev parent reply other threads:[~2018-03-21 12:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 19:00 [Qemu-devel] ihw/rdma: Implementation of Query QP verb Yuval Shaia
2018-03-20 19:00 ` [Qemu-devel] [PATCH v1 1/2] hw/rdma: Add Query QP operation Yuval Shaia
2018-03-20 19:00 ` [Qemu-devel] [PATCH v1 2/2] hw/rdma: Add support for Query QP verb to pvrdma device Yuval Shaia
2018-03-21 12:53 ` Marcel Apfelbaum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ff502e3-4623-a097-4b83-68b68d7a76aa@redhat.com \
--to=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).