qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
	qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	alex.bennee@linaro.org, Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: [Qemu-devel] action required for qemu-web committers (was Re: [qemu-web RFC PATCH] Update to Jekyll 4.0)
Date: Mon, 9 Sep 2019 14:50:04 +0200	[thread overview]
Message-ID: <601f8c37-354e-6b91-584a-a04e8b3f8438@redhat.com> (raw)
In-Reply-To: <20190906110649.9561-1-thuth@redhat.com>

On 06/09/19 13:06, Thomas Huth wrote:
> - Update versions in Gemfile
> - "has_key?" has to be renamed to "key?" in category_archive_plugin.rb
> - Add .jekyll-cache to .gitignore file
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

The software collections Ruby 2.5 was trivial to setup (patch to the hook
after my sig), so I went ahead and pushed this patch.  However, I encountered
a small snag for which I also had to add the "[PATCH qemu-web] use precompiled
sassc" that I have just sent.

Peter/Michael/Thomas, please ssh to qemu.org and do "rm -rf ~/bin ~/.gem"
(assuming you don't have any other binary in ~/bin :)).  In theory this
should not be needed, since bundler is now an RPM and the hook does not
add $HOME/bin to the PATH anymore.  However, it would be confusing for you
to have references to a Ruby installation that does not exist anymore on
the machine.

Note that the first time you push to qemu-web.git, you should expect a 
couple minutes of wait to install the updated gems to your home 
directory.

Paolo


--- update.old	2019-09-09 08:48:05.947586644 -0400
+++ update	2019-09-09 08:31:05.940274361 -0400
@@ -5,6 +5,8 @@
 #
 # Author: Paolo Bonzini
 
+source scl_source enable rh-ruby25
+
 # -----------------------------------------------------------------------------
 # $DEPLOY_ROOT is the path to the work area for this script.  All users
 # that can push to the repository must have write access to $DEPLOY_ROOT as
@@ -52,8 +54,7 @@
 # $DEPLOY_ROOT/root if successful.
 cd $DEPLOY_ROOT/source
 
-export PATH=$HOME/bin:$PATH
-bundle install
+bundle install --path $HOME/.gem
 if bundle exec jekyll build -d $DEPLOY_ROOT/new; then
   rm -rf $DEPLOY_ROOT/old
   if test -d $DEPLOY_ROOT/root; then


      parent reply	other threads:[~2019-09-09 12:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06 11:06 [Qemu-devel] [qemu-web RFC PATCH] Update to Jekyll 4.0 Thomas Huth
2019-09-09 12:31 ` Stefan Hajnoczi
2019-09-09 12:50 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=601f8c37-354e-6b91-584a-a04e8b3f8438@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).